docs: fix an example code for mouse click - #2043
Open
ydah wants to merge 1 commit into
Open
Conversation
❌ Deploy Preview for vue-test-utils-v1 failed.
|
This PR is fix an example code for mouse click.
The following error occurred when writing the test code as shown in the example.
```console
TypeError: Cannot read properties of undefined (reading 'have')
:
42|
43| spy.should.have.been.calledWith('yes')
| ^
44| })
45| })
```
ydah
force-pushed
the
fix-doc-example
branch
from
December 14, 2022 08:39
08b6afc to
48ed8dc
Compare
ydah
changed the title
Member
|
Hang on, this will depend on the test runner. I guess we should be clear about which runner the docs are using. Is there any other inconsistencies? |
Author
|
@lmiller1990 Thank you so much! Is there a test runner used in this document as a prerequisite? I may have missed it. |
Member
|
Actually, I guess it depends on the assert lib (jest's assertion chai, etc). We should likely do an audit and specify which runner we are using throughout the entire docs to make it consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR is fix an example code for mouse click.
The following error occurred when writing the test code as shown in the example.