Skip to content

fix(VSelect): add aria-label a11y #21181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

jcjp
Copy link
Contributor

@jcjp jcjp commented Mar 29, 2025

Description

Fixes: #21164

Missing aria-label on VList inside VSelect. Used axe developer tool to check if now fixed.

Markup:

<template>
  <v-app>
    <v-select
      label="Select"
      :menu="true"
      :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
    />
  </v-app>
</template>

@jcjp jcjp added T: bug Functionality that does not work as intended/expected a11y Accessibility issue C: VSelect labels Mar 29, 2025
@jcjp jcjp requested review from johnleider and Spatlani March 29, 2025 11:13
@jcjp jcjp self-assigned this Mar 29, 2025
@johnleider johnleider requested a review from KaelWD March 31, 2025 16:50
@johnleider
Copy link
Member

It seems simple enough but there is always subjectiveness when it comes to a11y. Hopefully kael can find time to comment.

@johnleider
Copy link
Member

Is this related to #20339 at all?

@jcjp
Copy link
Contributor Author

jcjp commented Apr 5, 2025

Is this related to #20339 at all?

Oh it seems to be related, on my side I modified the nested component VList while on that PR linked it is VVirtualScroll > VListItem > VCheckboxBtn.

@jcjp jcjp force-pushed the fix(VSelect)/list-a11y-label-missing branch from 9a41cb8 to a53266d Compare April 25, 2025 13:41
@jcjp jcjp merged commit 95c77fd into master Apr 25, 2025
18 checks passed
@jcjp jcjp deleted the fix(VSelect)/list-a11y-label-missing branch April 25, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue C: VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.7.19] V-select not passing accessibility checks
2 participants