fix(VOverlay): handle transition prop correctly for target assignment #22190
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the
VOverlay
component where thetarget
prop was being passed toMaybeTransition
regardless of the type of thetransition
prop. Thetarget
prop should only be passed when thetransition
prop is an object, not when it's a string transition name.Problem:
The
MaybeTransition
component was receiving atarget
value even when using string-based transitions, which cause an invalid attribute to appear in the DOM (target="[object HTMLButtonElement]"
)Solution:
Added a conditional check using
isObject(props.transition)
to only pass thetarget
prop toMaybeTransition
when the transition prop is an object. This ensures the target is only used for custom transition configurations that actually need it.Changes:
isObject
utility functiontarget={ isObject(props.transition) ? target.value : undefined }
Markup: