fix(v-intersect): auto-detect scrollable ancestor as root#22844
Open
VaishnaviD5900 wants to merge 2 commits intovuetifyjs:masterfrom
Open
fix(v-intersect): auto-detect scrollable ancestor as root#22844VaishnaviD5900 wants to merge 2 commits intovuetifyjs:masterfrom
VaishnaviD5900 wants to merge 2 commits intovuetifyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22147
When using
v-intersecton aVTimelineItem(or any element insidea scrollable container), the IntersectionObserver root was always null,
causing it to use the viewport instead of the nearest scrollable ancestor.
Root Cause
The
mountedfunction in the intersect directive created theIntersectionObserver with empty options
{}, defaulting root to null.Additionally, the DOM wasn't fully available at mount time.
Fix
getScrollableAncestor()helper that walks up the DOM to findthe nearest scrollable ancestor
nextTickto ensure DOM is fully mountedrootis provided, auto-detect the nearest scrollableancestor as the root
How to Test
v-intersecton aVTimelineIteminside a scrollable containerobserver.rootis the scrollable container, not nullisIntersectingcorrectly reflects visibility within the containerCloses
Closes #22147