fix(VSelect, VAutocomplete, VCombobox): default modelValue to undefined - #23097
Open
waterWang wants to merge 1 commit into
Open
fix(VSelect, VAutocomplete, VCombobox): default modelValue to undefined#23097waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
VSelect,VAutocomplete, orVComboboxis used without explicitly passingv-model, the defaultmodelValuewasnull. This caused a null-valued option in the items list to be unintentionally pre-selected, becauseuseProxiedModeltreatsnullas a valid value (not undefined), so it falls back to the defaultnullrather than the empty array.Root Cause
In all three components, the
modelValueprop default was set tonull:useProxiedModelchecksprops[prop] !== undefinedto decide whether to use the external value or the default. Sincenull !== undefinedistrue, the internal value becamenullinstead of the expected empty array[].Fix
Changed the default from
nulltoundefined. When nov-modelis provided:props.modelValueisundefineduseProxiedModelfalls back to thedefaultValue(empty array[])When
v-model="null"is explicitly passed, the behavior is unchanged — the option withvalue: nullis still correctly selected.Related Issues
Fixes #22126