fix(VNumberInput): resync display after model is overridden - #23099
Open
lazerg wants to merge 1 commit into
Open
fix(VNumberInput): resync display after model is overridden#23099lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The spin buttons set the display text from
model.value + stepand then push that number into the model. When the parent interceptsupdate:model-valueand writes back a different value,modelnever changes, so the watcher that refreshes the display never runs and the input keeps showing the rejected number. Stepping the other way then looks like it skips a step.toggleUpDownnow compares the model against the text once the update has settled and reformats the text when the two disagree.Fixes #23098
Markup: