fix(VSelect): correct focus resolution in Shadow DOM - #23102
Open
lazerg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inside a shadow root,
document.activeElementonly resolves to the shadow host, not the actual focused element, soonAfterEnter's containment check in VSelect always reports false and the fallback focus-move logic fires even when focus is already inside the list. This is the same issue #23024 and #23027 fixed for VDialog, VField, VTextField, and the rest; VSelect (and VAutocomplete/VCombobox by extension) was the one production usage they missed. Swappeddocument.activeElementfor the existinggetActiveElement()helper, the same one-line fix used in the sibling components.Fixes #23101
Markup: