feat!: drop CJS and use VueUse v13 #254

Tahul · 2025-03-09T23:45:06Z

❓ Type of change

👌 Enhancement (improving an existing functionality like performance)

📚 Description

Drop CJS support (like upcoming version of vueuse)
Update to latest available vueuse version
Drop prettier (unused)

BobbieGoede · 2025-03-10T00:30:51Z

I just marked it as breaking with feat!, but not sure if it is.

BobbieGoede · 2025-03-10T10:00:27Z

I think we can skip straight to vueuse v13 https://github.com/vueuse/vueuse/releases/tag/v13.0.0

pkg-pr-new · 2025-03-10T10:23:03Z

Open in Stackblitz

npm i https://pkg.pr.new/@vueuse/motion@254

commit: 22e7d2a

BobbieGoede · 2025-03-10T10:35:22Z

@userquin
Could you take a look at the exports/types stuff whether things look right? 🙏 I see you helped out with vueuse/vueuse#4581 too, you have the experience we lack 😅

userquin · 2025-03-10T11:18:42Z

ok, I'll check it later in the afternoon.

userquin · 2025-03-10T11:32:20Z

package.json

@@ -22,15 +22,12 @@
  "sideEffects": false,
  "exports": {
    ".": {
-      "import": "./dist/index.mjs",
-      "require": "./dist/index.cjs"
+      "import": "./dist/index.mjs"
    },


use ".": "./dist/index.mjs"

userquin · 2025-03-10T11:32:38Z

package.json

    },
    "./nuxt": {
-      "import": "./dist/nuxt/module.mjs",
-      "require": "./dist/nuxt/module.cjs"
+      "import": "./dist/nuxt/module.mjs"


use "./nuxt": "./dist/module.mjs"

userquin · 2025-03-10T11:38:51Z

package.json

    }
  },
-  "main": "./dist/index.cjs",
  "module": "./dist/index.mjs",
  "types": "./dist/index.d.ts",
  "typesVersions": {


since we're not using .js in the file extensions in the package, we need to add the d.mts for nuxt , "./*" isn't effective:

"typesVersions": { "*": { "nuxt": [ "./dist/nuxt/module.d.mts" ] } }

So should we have the following?

"typesVersions": { "*": { "*": [ "./dist/*", "./*" ], "nuxt": [ "./dist/nuxt/module.d.mts" ] } },

or just use .js instead .mjs and keep current "typesVersions"

So should we have the following?

"typesVersions": { "*": { "*": [ "./dist/*", "./*" ], "nuxt": [ "./dist/nuxt/module.d.mts" ] } },

no, just nuxt entry

in fact Nuxt will drop support for node10 module resolution (if not yet removed), we can remove "typesVersions" entry

Nuxt still supports node 10 , so it is fine

userquin · 2025-03-10T11:40:01Z

build.config.ts

@@ -2,7 +2,7 @@ import { defineBuildConfig } from 'unbuild'

 export default defineBuildConfig({
  rollup: {
-    emitCJS: true,
+    emitCJS: false,


remove rollup entry, and change declaration to node16

userquin · 2025-03-10T11:41:24Z

package.json

    }
  },
-  "main": "./dist/index.cjs",
  "module": "./dist/index.mjs",
  "types": "./dist/index.d.ts",


use "types": "./dist/index.d.mts",

userquin · 2025-03-10T11:53:33Z

package.json

@@ -106,7 +103,6 @@
    "lint-staged": "^15.2.5",
    "nuxt": "^3.13.0",
    "pkg-pr-new": "^0.0.20",
-    "prettier": "^3.2.5",
    "typescript": "^5.4.5",
    "unbuild": "^2.0.0",


we should also update typescript and unbuild versions

userquin · 2025-03-10T12:24:36Z

package.json

  },
-  "main": "./dist/index.cjs",


add the main entry using "main": "./dist/index.mjs",

userquin · 2025-03-10T12:34:19Z

update tsconfig.json file removing vue-demi from paths, switch to "moduleResolution": "Bundler" and include these 2 changes:

"moduleDetection": "force",
"module": "preserve",

userquin · 2025-03-10T13:00:06Z

We should switch tests to use Vitest Browser Mode and test the library in the browser.

Tahul added 8 commits March 10, 2025 00:42

fix drop unused ts-expect-error

fe96dbc

feat add type hint in index

45d3613

feat update vueuse useMediaQuery usage

01f638f

feat useMotionControls.ts ; add typehint

90da3bd

feat useMotionVariants.ts ; add type hint

c995559

feat drop prettier

d7f2a5e

feat drop cjs in build.config & package.json

77b45c1

feat global

ef6e36f

Tahul requested a review from BobbieGoede March 9, 2025 23:45

BobbieGoede changed the title ~~feat: vueuse maintenance update~~ feat!: vueuse maintenance update Mar 10, 2025

BobbieGoede added 4 commits March 10, 2025 11:03

fix: linting errors

ae47631

chore(deps): update vueuse dependencies

19315fe

ci: fix corepack

3df5c4e

chore: remove unused script

a1b1ac8

BobbieGoede added the cr-tracked label Mar 10, 2025

BobbieGoede changed the title ~~feat!: vueuse maintenance update~~ feat!: drop CJS and use VueUse v13 Mar 10, 2025

BobbieGoede mentioned this pull request Mar 10, 2025

chore: upgrade deps #251

Closed

9 tasks

userquin reviewed Mar 10, 2025

View reviewed changes

BobbieGoede added 2 commits March 10, 2025 13:11

build: configure unbuild declaration node16

9d85cc8

fix: package exports and types

1a2d483

userquin reviewed Mar 10, 2025

View reviewed changes

package.json

},

"main": "./dist/index.cjs",

Copy link

Contributor

userquin Mar 10, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the main entry using "main": "./dist/index.mjs",

BobbieGoede added 5 commits March 10, 2025 13:35

fix: update typescript and unbuild and fix build

6795d5a

fix: linting errors

a38df57

fix: disable ssg prettify to prevent prettier failure

a8c4ce7

fix: add back main entry

0df607d

test: wait for duration of variant transition

53fe1bc

BobbieGoede added 2 commits March 10, 2025 14:35

chore: update pnpm and node versions

d82eb9b

chore: add contributors to package

22e7d2a

BobbieGoede approved these changes Mar 10, 2025

View reviewed changes

BobbieGoede merged commit d6dcf8f into main Mar 10, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: drop CJS and use VueUse v13 #254

feat!: drop CJS and use VueUse v13 #254

Tahul commented Mar 9, 2025

BobbieGoede commented Mar 10, 2025

BobbieGoede commented Mar 10, 2025

pkg-pr-new bot commented Mar 10, 2025 •

edited

Loading

BobbieGoede commented Mar 10, 2025

userquin commented Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025 •

edited

Loading

BobbieGoede Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025

userquin Mar 10, 2025 •

edited

Loading

userquin commented Mar 10, 2025 •

edited

Loading

userquin commented Mar 10, 2025 •

edited

Loading

feat!: drop CJS and use VueUse v13 #254

feat!: drop CJS and use VueUse v13 #254

Conversation

Tahul commented Mar 9, 2025

❓ Type of change

📚 Description

BobbieGoede commented Mar 10, 2025

BobbieGoede commented Mar 10, 2025

pkg-pr-new bot commented Mar 10, 2025 • edited Loading

BobbieGoede commented Mar 10, 2025

userquin commented Mar 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

userquin Mar 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

userquin Mar 10, 2025 • edited Loading

Choose a reason for hiding this comment

userquin commented Mar 10, 2025 • edited Loading

userquin commented Mar 10, 2025 • edited Loading

pkg-pr-new bot commented Mar 10, 2025 •

edited

Loading

userquin Mar 10, 2025 •

edited

Loading

userquin Mar 10, 2025 •

edited

Loading

userquin commented Mar 10, 2025 •

edited

Loading

userquin commented Mar 10, 2025 •

edited

Loading