Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: externalize CSSProperties types #255

Merged

Conversation

BobbieGoede
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The types extending or using CSSProperties interface types are somehow being inlined, increasing the build size significantly. For some reason adding type annotations seems to prevent this from happening, it's not pretty but saves a lot of space.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Mar 10, 2025
Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@vueuse/motion@255

commit: c83fc77

Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@vueuse/motion@255

commit: 43221cb

@BobbieGoede BobbieGoede requested a review from Tahul March 10, 2025 18:01
@BobbieGoede
Copy link
Member Author

The changes in this PR likely reintroduce #228, I am unable to test it as the reproduction has expired..

@BobbieGoede BobbieGoede merged commit f1d52d3 into vueuse:main Mar 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant