Remove unnecessary functionality from escapeOrCleanHtml #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm looking through EscapeOrCleanHtmlTest, and also CleanHtmlTest, and not finding this test -- where is it? Trying to make it fail with the behavior you saw before I test the fix. Just running the test classes with PhpUnitFast isn't making them fail. |
|
@maccabeelevine, it's one of the Mink integration tests that's failing; the unit tests don't catch this. You can see the details if you look at Jenkins. |
module/VuFind/src/VuFind/View/Helper/Root/EscapeOrCleanHtml.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/View/Helper/Root/EscapeOrCleanHtml.php
Outdated
Show resolved
Hide resolved
demiankatz
changed the title
maccabeelevine
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escapeOrCleanHtml included a mechanism for obtaining the whole object through the
__invokemethod, but this was neither used nor needed and had the potential to cause weird side effects. This PR simplifies the helper by removing the unwanted logic.