Improve abstract plugin factories#4801
Improve abstract plugin factories#4801demiankatz wants to merge 20 commits intovufind-org:dev-12.0from
Conversation
|
I think this is a good idea. I'm not sure if it's feasible to apply to the top-level service manager, though. Perhaps it would be better to limit this to plugin managers at least for now. |
Commit 911dfac contains a proof of concept for abstract top-level service handling which greatly reduces the configuration and doesn't seem to break anything. We can likely reduce it further with some minor tweaks. Note that my work should definitely be carefully reviewed in case I deleted something I shouldn't have, but all Mink tests are passing, so if I made a mistake, it's probably in an obscure area. |
This is a proof of concept which makes the AbstractPluginFactory smarter, so it can take advantage of existing factories based on a naming convention. In theory, this could greatly reduce the size of our factory configuration, though at the cost of less explicit/more "magical" behavior.
TODO