Convert Reserves plugin to service helper#4923
Merged
demiankatz merged 10 commits intovufind-org:dev-12.0from Dec 3, 2025
Merged
Convert Reserves plugin to service helper#4923demiankatz merged 10 commits intovufind-org:dev-12.0from
demiankatz merged 10 commits intovufind-org:dev-12.0from
Conversation
demiankatz
requested changes
Dec 2, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @sambhavp96, see below for one small suggestion. Other than that, the only thing is to add some test coverage if possible/practical.
demiankatz
added
the
architecture
demiankatz
approved these changes
Dec 3, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @sambhavp96! I made a couple of last-minute adjustments here to get it done (renaming the factory, plus some minor tweaks to the helper constructor and test), since I know you won't be back until next week. Enjoy the rest of the week, and see you next week!
stweil
pushed a commit
to stweil/vufind
that referenced
this pull request
Jan 14, 2026
stweil
pushed a commit
to stweil/vufind
that referenced
this pull request
Jan 19, 2026
stweil
pushed a commit
to stweil/vufind
that referenced
this pull request
Jan 20, 2026
stweil
pushed a commit
to stweil/vufind
that referenced
this pull request
Jan 22, 2026
stweil
pushed a commit
to stweil/vufind
that referenced
this pull request
Jan 24, 2026
stweil
pushed a commit
to stweil/vufind
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.