Add parent_config_name directive to YAML reader#4930
Merged
demiankatz merged 8 commits intovufind-org:devfrom Dec 4, 2025
Merged
Conversation
demiankatz
requested changes
Dec 4, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @ThoWagen, this looks good to me; just see below for some nitpicks.
I assume that in future, we will generalize things further so that the parent configuration might be in a different format and loaded from the config manager. But for now, this is a good first step that adds functionality without breaking anything!
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
requested changes
Dec 4, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @ThoWagen, this looks good to me now -- but the build still appears to be failing with a minor style issue.
Contributor
Author
|
Fixed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here #4845 (comment), this PR adds the option to use another configuration name instead of a specific file as parents in YAML configuration.