Add support for "new items" facet. #4996
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Jan 14, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks for getting this started, @EreMaijala. I haven't had a chance to do any hands-on testing or to review everything carefully, but see below for a few minor things.
I'll comment further when I have a bit more time!
Comment on lines
+1993
to
+1998
| * @param string|object|array $target String to translate or an array of text | ||
| * domain and string to translate | ||
| * @param array $tokens Tokens to inject into the translated | ||
| * string | ||
| * @param string $default Default value to use if no translation is | ||
| * found (null for no default). |
Member
There was a problem hiding this comment.
Minor formatting suggestions:
Suggested change
| * @param string|object|array $target String to translate or an array of text | |
| * domain and string to translate | |
| * @param array $tokens Tokens to inject into the translated | |
| * string | |
| * @param string $default Default value to use if no translation is | |
| * found (null for no default). | |
| * @param string|object|array $target String to translate or an array of text | |
| * domain and string to translate | |
| * @param array $tokens Tokens to inject into the translated string | |
| * @param string $default Default value to use if no translation is | |
| * found (null for no default). |
| * | ||
| * @return string | ||
| */ | ||
| public function replaceFacet($field, $value, $operator = 'AND') |
Member
There was a problem hiding this comment.
Might as well add types to new methods...
Suggested change
| public function replaceFacet($field, $value, $operator = 'AND') | |
| public function replaceFacet(string $field, string $value, string $operator = 'AND'): static |
| * @param string $value Facet value | ||
| * @param string $operator Facet type to add (AND, OR, NOT) | ||
| * | ||
| * @return string |
Member
There was a problem hiding this comment.
Pretty sure this isn't returning a string...
Suggested change
| * @return string | |
| * @return static |
| "version": "2.11.8", | ||
| "resolved": "https://registry.npmjs.org/@popperjs/core/-/core-2.11.8.tgz", | ||
| "integrity": "sha512-P1st0aksCrn9sGZhp8GMYwBnQsbvAWsZAX44oXNNvLHGqAOcoVxmjZiohstwQ7SqKnbR47akdNi+uleWD8+g6A==", | ||
| "peer": true, |
Member
There was a problem hiding this comment.
This random change again!
Suggested change
| "peer": true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: