Refactor View Helpers to use constructor injection and Autowiring #5011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Jan 14, 2026
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @sambhavp96, this is off to a good start -- and I really like how this refactoring reduces the complexity of testing!
I just spotted one thing that seems like a problem so far (see below).
Beyond that, let me know if you would like me to approve and merge your progress here in chunks across multiple PRs, or if you prefer to complete the whole project and merge it all at once.
Comment on lines
-64
to
-65
| $useIcuFormatter = false, | ||
| $fallbackDomains = [] |
Member
There was a problem hiding this comment.
These parameters seem to have gotten lost in the refactoring somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.