Skip to content

Conversation

@stweil
Copy link
Contributor

@stweil stweil commented Jan 17, 2026

No description provided.

@stweil
Copy link
Contributor Author

stweil commented Jan 17, 2026

Commit 0aa344b fixed logout in all auth handlers which used it, but for OpenIDConnect the logout function was added later in ddb53bc. It was working for release 10, but not for releases 11 and 12.

@stweil
Copy link
Contributor Author

stweil commented Jan 17, 2026

Without this fix, I get the runtime exception "Deprecated methods "logout" and "resetState" needto be replaced by "getLogoutRedirectUrl" and "clearLoginState". Note the missing blank which is fixed in a 2nd commit which I just added.

@stweil
Copy link
Contributor Author

stweil commented Jan 17, 2026

I still wonder why I got the runtime exception on our test instance after upgrading from release 10 to release 11, while my 2nd test instance which is based on dev-12.0 does not throw this exception although it has the same bug.

The exception also occurs with dev-12.0 when the authentication method is set to "OpenIDConnect".

@demiankatz demiankatz added this to the 11.0.1 milestone Jan 17, 2026
@demiankatz demiankatz changed the base branch from dev to release-11.0 January 17, 2026 12:57
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stweil -- this must be a case of two interrelated pull requests getting merged close together without the conflict being noticed. Good catch! I'll merge this today so we can include it in the 11.0.1 bug fix release on Monday.

@demiankatz demiankatz merged commit acde2b9 into vufind-org:release-11.0 Jan 17, 2026
6 checks passed
@stweil stweil deleted the fix_oidc branch January 17, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants