[A11y] Fix id / aria-labelledby combinations

[rominail]

Some aria-labelledby are displayed while the associated id is not

[demiankatz]

Thanks, @rominail -- see below for a stylistic suggestion.

Beyond that, a couple of other thoughts:

1.) It might be worth considering using the htmlAttributes view helper with an array to build these divs -- could further improve readability. I leave it to your preference, though!

2.) I'm a little confused about the intent of the label in facet-list.phtml -- I wonder if that markup needs overall improvement beyond just this small fix. I think @mtrojan-ub built that control originally, so if there are questions, maybe his input will be helpful.

[rominail]

1.) It might be worth considering using the htmlAttributes view helper with an array to build these divs -- could further improve readability. I leave it to your preference, though!

Done

2.) I'm a little confused about the intent of the label in facet-list.phtml -- I wonder if that markup needs overall improvement beyond just this small fix. I think @mtrojan-ub built that control originally, so if there are questions, maybe his input will be helpful.

I was too but I chose to only fix the aria-labelledby mismatch, instead of risking breaking anything.
I'm open to anyone improving the code (which was bigger than the PR intended scope)

PS : One test is failing with an authentication problem if you don't mind taking a look