Refactor CoverController to actions.#5367
Open
EreMaijala wants to merge 1 commit into
Open
Conversation
demiankatz
requested changes
Jun 11, 2026
demiankatz
left a comment
demiankatz
left a comment
Member
There was a problem hiding this comment.
Thanks, @EreMaijala -- see below for some minor questions/comments.
| * @return ResponseInterface | ||
| */ | ||
| public function action( | ||
| ServerRequestInterface $request, |
Member
There was a problem hiding this comment.
Do we need an unused parameter annotation here since $request is not used? (I imagine this may be a widespread problem...)
| // then on each page load. Default TTL set at 14 days | ||
| if ($this->config['Content']['coverimagesBrowserCache'] ?? true) { | ||
| $coverImageTtl = (60 * 60 * 24 * 14); // 14 days | ||
| $response = $response->withHeader( |
Member
There was a problem hiding this comment.
Maybe this is a follow-up action, but do we want to have a cache control helper so we can centralize and reuse this type of logic?
| * @return ResponseInterface | ||
| */ | ||
| public function action( | ||
| ServerRequestInterface $request, |
demiankatz
added
the
architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.