Skip to content

Improve configuration robustness and fix Docker deployment#17

Merged
adulau merged 3 commits into
vulnerability-lookup:mainfrom
oh2fih:default-settings
Sep 7, 2025
Merged

Improve configuration robustness and fix Docker deployment#17
adulau merged 3 commits into
vulnerability-lookup:mainfrom
oh2fih:default-settings

Conversation

@oh2fih

@oh2fih oh2fih commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

This PR fixes a configuration key mismatch in the Docker setup, makes the Valkey database number configurable, and embeds the documented defaults directly into the code. These changes ensure the application runs reliably even when configuration files are missing or incomplete.

Fixes #16

Embed the defaults already defined in settings.yaml directly into the
code. This ensures the application runs even if the configuration file
is missing or incomplete, while keeping consistency with the documented
defaults.
@oh2fih

oh2fih commented Sep 7, 2025

Copy link
Copy Markdown
Contributor Author

Validation of configuration values before use could further improve robustness, enabling either:

  • fallback to default values instead of crashing, or
  • human-readable error messages instead of stack traces.

@adulau adulau merged commit 2a002be into vulnerability-lookup:main Sep 7, 2025
2 checks passed
@adulau

adulau commented Sep 7, 2025

Copy link
Copy Markdown
Member

Thank you!

@oh2fih oh2fih deleted the default-settings branch September 7, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'Settings' object has no attribute 'VALKEY'

2 participants