Skip to content

fix: pr comments#21

Merged
adulau merged 2 commits into
vulnerability-lookup:mainfrom
qjerome:fix-pr-comments
Feb 11, 2026
Merged

fix: pr comments#21
adulau merged 2 commits into
vulnerability-lookup:mainfrom
qjerome:fix-pr-comments

Conversation

@qjerome

@qjerome qjerome commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Fixes a bunch of comments in: #20

@oh2fih

oh2fih commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

As the location changes, this would be a good PR to fix the documentation:

  • How these are supposed to be used directly?
  • Hot to use them via uv.

@qjerome

qjerome commented Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

We plan to do major modifications to cpe-guesser very likely leading to a new major version of the project, the uv-ify PR being only the first one of a series just to cleanup the project and start on a clean base. I don't want to invest to much time at fixing the current documentation and the README for the moment as the new implementation is still evolving. What I can do though is put a warning on top of the README asking people to use the latest stable release 1.2.0 instead of relying on the git version (which anyway is discouraged if you expect stable behaviour).

@adulau adulau merged commit 41c3689 into vulnerability-lookup:main Feb 11, 2026
2 checks passed
@adulau

adulau commented Feb 11, 2026

Copy link
Copy Markdown
Member

Thank you!

@oh2fih

oh2fih commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

We plan to do major modifications to cpe-guesser very likely leading to a new major version of the project, the uv-ify PR being only the first one of a series just to cleanup the project and start on a clean base.

That clarifies a lot, thank you. Please feel free to keep me in the loop — I’d be happy to share thoughts on how to keep cpe-guesser broadly usable as a standalone library outside the scope of vulnerability-lookup, as it previously was within the cve-search project.

@adulau

adulau commented Mar 22, 2026

Copy link
Copy Markdown
Member

Following some different feedback, I roll-backed the changes and the UVify into develop branch and main is back to before the merge of the UVify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants