Handle incomplete/multiline NDJSON records in CVEListV5Handler and add tests#25
Merged
adulau merged 1 commit intoMar 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
process_ndjson_fileto buffer consecutive lines intopending_linesand attempt to parse a combined payload before skipping.�_load_record�,�_is_incomplete_record�,�_looks_like_record_start�,�_process_record�, and�_skip_invalid_record�and theINCOMPLETE_ERROR_PREFIXESconstant to centralize parsing and error handling.record_progressandprocess_rank_batchwhile skipping only truly invalid or incomplete records.test_skips_single_invalid_multiline_record_and_continuesto verify a broken multiline record is skipped and processing continues for following valid records.Testing
tests/test_cvelistv5.pyunit tests which include the newtest_skips_single_invalid_multiline_record_and_continuestest.Codex Task