Skip to content

fix: hide reshare option when vault has MLDSA key#3946

Open
johnnyluo wants to merge 1 commit intomainfrom
hide-reshare-for-mldsa-vaults
Open

fix: hide reshare option when vault has MLDSA key#3946
johnnyluo wants to merge 1 commit intomainfrom
hide-reshare-for-mldsa-vaults

Conversation

@johnnyluo
Copy link
Contributor

@johnnyluo johnnyluo commented Mar 4, 2026

Summary

  • Hide the reshare option in vault advanced settings when the vault has an MLDSA key (publicKeyMLDSA44 != nil)
  • MLDSA keys do not support reshare yet, so the option should not be visible for those vaults

Test Plan

  • Open a vault without an MLDSA key → reshare option is visible (existing fast vault excluded)
  • Generate an MLDSA key for a vault → reshare option is hidden
  • SwiftLint passes (no new violations)

Co-Authored-By: Claude noreply@anthropic.com

Summary by CodeRabbit

  • Bug Fixes
    • Updated vault reshare option visibility to properly account for additional vault configurations, improving the accuracy of when the reshare feature appears in vault settings.

MLDSA key doesn't support reshare yet, so the reshare option is now
hidden in vault advanced settings when publicKeyMLDSA44 is present.

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bbef432-d4f3-4231-8941-428dbea6fdb4

📥 Commits

Reviewing files that changed from the base of the PR and between 7183647 and 6f45198.

📒 Files selected for processing (1)
  • VultisigApp/VultisigApp/Views/Vault/Settings/VaultAdvancedSettingsScreen.swift

Walkthrough

Modified the Reshare row visibility condition in VaultAdvancedSettingsScreen.swift to require both the vault is not fast and publicKeyMLDSA44 is nil, adding an additional check to hide the option when an MLDSA44 key already exists.

Changes

Cohort / File(s) Summary
Reshare Visibility Logic
VultisigApp/VultisigApp/Views/Vault/Settings/VaultAdvancedSettingsScreen.swift
Updated Reshare row visibility condition to check both vault.isFast and publicKeyMLDSA44 nil status, preventing the option from appearing when an MLDSA44 key is already present.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: hiding the reshare option when a vault has an MLDSA key, which is the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hide-reshare-for-mldsa-vaults

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant