This repository was archived by the owner on Aug 15, 2025. It is now read-only.
T7658: Fix default max-map-count and add smoketest for this parameter - #54
Closed
natali-rs1985 wants to merge 1 commit into
Closed
T7658: Fix default max-map-count and add smoketest for this parameter#54natali-rs1985 wants to merge 1 commit into
natali-rs1985 wants to merge 1 commit into
Conversation
natali-rs1985
requested review from
dmbaturin,
jestabro,
sever-sever and
zdc
as code owners
July 25, 2025 07:32
sever-sever
suggested changes
Jul 25, 2025
sever-sever
left a comment
Contributor
There was a problem hiding this comment.
Please add a smoketest to check this feature and actual settings of the sysctl.
As it wasn't working for months.
natali-rs1985
force-pushed
the
T7658-fix-default-max_map_count
branch
from
July 25, 2025 14:13
8d7d9fa to
0810db8
Compare
Contributor
Author
Added smoketest |
dmbaturin
approved these changes
Jul 26, 2025
dmbaturin
left a comment
Contributor
There was a problem hiding this comment.
The change is sensible and there's a test, no objections.
sever-sever
suggested changes
Jul 27, 2025
Comment on lines
+1411
to
+1414
| self.cli_delete(hr_path + ['max-map-count']) | ||
| self.cli_commit() | ||
|
|
||
| self.assertEqual(sysctl_read('vm.max_map_count'), max_map_count) |
Contributor
There was a problem hiding this comment.
If we delete the max-map-count option, the expected default value is 65530 and not 100_000
natali-rs1985
force-pushed
the
T7658-fix-default-max_map_count
branch
from
July 28, 2025 08:54
0810db8 to
f0708b2
Compare
In the code we have the restriction not to decrease values in host-resources section. We need to skip this smoketest for now until we remove the restriction because it will always fail
natali-rs1985
force-pushed
the
T7658-fix-default-max_map_count
branch
from
July 28, 2025 08:56
f0708b2 to
e5ff51a
Compare
Contributor
Author
|
Close this PR due to moving functionality to "system option host-resources" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the code we have the restriction not to decrease values in host-resources section. We need to skip this smoketest for now until we remove the restriction because it will always fail
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
How to test
Checklist: