T8852: migrate .github/mergify.yml to extends: mergify#17
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used🔍 Remote MCP Context7Summary of Relevant Mergify Configuration Information
|
| Layer / File(s) | Summary |
|---|---|
Mergify baseline inheritance .github/mergify.yml |
Inline pull_request_rules (conflict PR labeling) and commands_restrictions (backport/command authorization) removed. Configuration now extends central mergify baseline via extends: mergify. |
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | Title directly and accurately describes the main change: migrating the Mergify configuration to use the extends: mergify pattern. |
| Description check | ✅ Passed | Description comprehensively explains the rationale, affected stanzas, central baseline location, and testing approach—clearly related to the changeset. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
✨ Simplify code
- Create PR with simplified code
- Commit simplified code in branch
T8852-mergify-extends
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
|
@copilot review |
Reviewed on commit |
jestabro
left a comment
There was a problem hiding this comment.
Replace inline Mergify config with per-org version via extends directive.
Change Summary
Replace the inline T8531 predecessor Mergify config in
.github/mergify.ymlwithextends: mergify, deferring to the per-org central baseline (vyos/mergify on the vyos side, VyOS-Networks/mergify on the mirror).Types of changes
Related Task(s)
extends:fleet migrationRelated PR(s)
extends:template: vyos/vyos-documentation/.github/mergify.yml.Component(s) name
CI / Mergify configuration
Proposed changes
Old
.github/mergify.ymlinlined two stanzas verbatim from the T8531 predecessor rollout:pull_request_rules— label conflicting PRs withconflicts.commands_restrictions— restrict @Mergifyio slash commands to@vyos/maintainers+vyosbot.Both stanzas now live in the per-org central baseline at vyos/mergify:.mergify.yml and VyOS-Networks/mergify:.mergify.yml. The central baseline also adds:
defaults.actions.backport.ignore_conflicts: falseinvalid-titlelabel)This PR replaces the inline content with a single
extends: mergifydirective. Per Mergifyextends:semantics,mergifyis resolved within the same org — so:vyos/libnss-mapuser→ resolves tovyos/mergify(uses@vyos/maintainers)VyOS-Networks/libnss-mapuser(if applicable) → resolves toVyOS-Networks/mergify(uses@VyOS-Networks/maintainers)How to test
After merge, a Maintainer can comment
@Mergifyio backport <branch>on a merged PR. Mergify should accept the command and create the backport PR. Pre-merge, Mergify itself surfaces config errors as PR comments if the YAML is malformed.Smoketest result
N/A — CI/Mergify-only change.
Checklist:
Backport
If the repo carries this file on
circinusandsagittabranches as well, backport via@Mergifyio backport circinus sagittaafter merge.🤖 Generated by robots