Skip to content

T7488: call utility to rollback vpp section of config after apply stage error #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jun 10, 2025

Change Summary

This requires PR vyos/vyos-1x#4552 to be merged first.

Call rollback utility needed for VPP restart. It is a no-op if vpp is not configured.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-1x#4552
vyos/vyos-vpp#34

Component(s) name

Proposed changes

How to test

Tested by @natali-rs1985 in the context of vyos/vyos-vpp#34

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Jun 10, 2025
Copy link

github-actions bot commented Jun 10, 2025

👍
No issues in PR Title / Commit Title

@jestabro jestabro changed the title T7488: call utility to rollback vpp section of config after apply stage failure T7488: call utility to rollback vpp section of config after apply stage error Jun 10, 2025
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward companion to the PR that adds a section rollback utility, no objections.

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, works as expected

@sever-sever sever-sever merged commit 74bb4ab into vyos:current Jun 12, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants