Sflow: T7175: Added VPP option - #4504
Closed
ServerForge wants to merge 2 commits into
Closed
Conversation
|
❌ |
11 tasks
sever-sever
requested changes
Jul 18, 2025
sever-sever
left a comment
Member
There was a problem hiding this comment.
Rebase please and add commit messgae in this format Sflow: T7175: Added VPP option (use commit --amend and force push)
|
All contributors have signed the CLA ✍️ ✅ |
|
CI integration 👍 passed! Details
|
sever-sever
self-requested a review
July 21, 2025 17:15
sever-sever
requested changes
Jul 23, 2025
sever-sever
left a comment
Member
There was a problem hiding this comment.
Squash please PR to one commit
sever-sever
reviewed
Jul 23, 2025
| <valueless/> | ||
| </properties> | ||
| </leafNode> | ||
| <leafNode name="enable-vpp"> |
Member
There was a problem hiding this comment.
What do you think about just vpp ?
set system sflow vpp
Contributor
Author
|
I cant seem to get this to squash properly, il just redo it later when i get some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Updated hsflowd CLI to have VPP option and updated error check to handle interface checks when using VPP.
Types of changes
Related Task(s)
https://vyos.dev/T7175
Related PR(s)
vyos/vyos-build#962
vyos-legacy/vyos-vpp#32
How to test / Smoketest result
Checklist: