Skip to content

Sflow: T7175: Added VPP option - #4504

Closed
ServerForge wants to merge 2 commits into
vyos:currentfrom
ServerForge:current
Closed

Sflow: T7175: Added VPP option#4504
ServerForge wants to merge 2 commits into
vyos:currentfrom
ServerForge:current

Conversation

@ServerForge

Copy link
Copy Markdown
Contributor

Change summary

Updated hsflowd CLI to have VPP option and updated error check to handle interface checks when using VPP.

vyos@vyos# set system sflow 
Possible completions:
   agent-address        sFlow agent IPv4 or IPv6 address
   agent-interface      IP address associated with this interface
   drop-monitor-limit   Export headers of dropped by kernel packets
   enable-egress        Enable egress sampling
   enable-vpp           Enable VPP sampling
+  interface            Interface
   polling              Schedule counter-polling in seconds (default: 30)
   sampling-rate        sFlow sampling-rate (default: 1000)
+> server               sFlow destination server
   vrf                  VRF instance name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7175

Related PR(s)

vyos/vyos-build#962
vyos-legacy/vyos-vpp#32

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Updated hsflowd CLI to have VPP option and updated error check to handle interface checks when using VPP.
@github-actions

github-actions Bot commented May 12, 2025

Copy link
Copy Markdown


PR title does not match the required format

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase please and add commit messgae in this format Sflow: T7175: Added VPP option (use commit --amend and force push)

@github-actions

github-actions Bot commented Jul 18, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever
sever-sever self-requested a review July 21, 2025 17:15

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash please PR to one commit

@sever-sever
sever-sever requested a review from dmbaturin July 23, 2025 08:29
<valueless/>
</properties>
</leafNode>
<leafNode name="enable-vpp">

@sever-sever sever-sever Jul 23, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about just vpp ?

set system sflow vpp

@ServerForge

Copy link
Copy Markdown
Contributor Author

I cant seem to get this to squash properly, il just redo it later when i get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants