Skip to content

op-mode: T7538: remove the obsolete "show login level" command #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

dmbaturin
Copy link
Member

Change summary

The old command run show login level is a legacy of the Vyatta days: it uses an implementation detail of the old scripts to determine if the current user is an admin or an operator, and also assumes that admin/operator distinctions are binary.

It's effectively useless now and will break when we introduce the new op mode permissions system, so we should remove it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): legacy functionality removal.

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jun 9, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Jun 9, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not having levels at the moment

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have login levels

@dmbaturin dmbaturin added the bp/circinus Create automatic backport for circinus label Jun 10, 2025
@dmbaturin dmbaturin merged commit fbaf05c into vyos:current Jun 10, 2025
17 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label Jun 10, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus current mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants