Skip to content

T7175: Added VPP option - #4621

Merged
sever-sever merged 2 commits into
vyos:currentfrom
ServerForge:current
Jul 25, 2025
Merged

T7175: Added VPP option#4621
sever-sever merged 2 commits into
vyos:currentfrom
ServerForge:current

Conversation

@ServerForge

Copy link
Copy Markdown
Contributor

Change summary

Updated hsflowd CLI to have VPP option and updated error check to handle interface checks when using VPP.

vyos@vyos# set system sflow 
Possible completions:
   agent-address        sFlow agent IPv4 or IPv6 address
   agent-interface      IP address associated with this interface
   drop-monitor-limit   Export headers of dropped by kernel packets
   enable-egress        Enable egress sampling
   vpp                  Enable VPP sampling
+  interface            Interface
   polling              Schedule counter-polling in seconds (default: 30)
   sampling-rate        sFlow sampling-rate (default: 1000)
+> server               sFlow destination server
   vrf                  VRF instance name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7175

Related PR(s)

vyos/vyos-build#962
vyos-legacy/vyos-vpp#32

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions

github-actions Bot commented Jul 24, 2025

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

Comment thread interface-definitions/system_sflow.xml.in Outdated

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add VPP option to configure system sFlow

vyos@r14# set system sflow 
Possible completions:
   agent-address        sFlow agent IPv4 or IPv6 address
   agent-interface      IP address associated with this interface
   drop-monitor-limit   Export headers of dropped by kernel packets
   enable-egress        Enable egress sampling
+  interface            Interface
   polling              Schedule counter-polling in seconds (default: 30)
   sampling-rate        sFlow sampling-rate (default: 1000)
+> server               sFlow destination server
   vpp                  Enable VPP sampling
   vrf                  VRF instance name


@sever-sever

Copy link
Copy Markdown
Member

Smoketest passed

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_system_sflow.py
DEBUG - test_sflow (__main__.TestSystemFlowAccounting.test_sflow) ... ok
DEBUG - test_vrf (__main__.TestSystemFlowAccounting.test_vrf) ... ok
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 2 tests in 13.524s
DEBUG - 
DEBUG - OK

@sever-sever
sever-sever merged commit 819fcff into vyos:current Jul 25, 2025
14 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jul 25, 2025
@github-actions

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants