-
Notifications
You must be signed in to change notification settings - Fork 453
T75: migrate from pmacct to ipt_NETFLOW #4688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| {% if netflow.engine_id is vyos_defined %} | ||
| options ipt_NETFLOW engine-id={{ netflow.engine_id }} | ||
| {% endif %} | ||
| {% if netflow.max_flows is vyos_defined %} | ||
| options ipt_NETFLOW maxflows={{ netflow.max_flows }} | ||
| {% endif %} | ||
| {% if netflow.sampling_rate is vyos_defined %} | ||
| options ipt_NETFLOW sampler=random:{{ netflow.sampling_rate }} | ||
| {% endif %} | ||
| {% if netflow.server is vyos_defined %} | ||
| {% set servers_list = [] %} | ||
| {% for server in netflow.server %} | ||
| {% set d = netflow.server[server] %} | ||
| {% set s = (server | bracketize_ipv6) ~ ':' ~ d['port'] %} | ||
| {% set s = s ~ ('%' ~ d['source_interface'] if d['source_interface'] is vyos_defined else '') %} | ||
| {% set s = s ~ ('@' ~ d['source_address'] if d['source_address'] is vyos_defined else '') %} | ||
| {% set _ = servers_list.append(s) %} | ||
| {% endfor %} | ||
| options ipt_NETFLOW destination={{ servers_list | join(",") }} | ||
| {% endif %} | ||
| {% if netflow.version is vyos_defined %} | ||
| options ipt_NETFLOW protocol={{ netflow.version }} | ||
| {% endif %} | ||
| {% if netflow.inactive_timeout is vyos_defined %} | ||
| options ipt_NETFLOW inactive_timeout={{ netflow.inactive_timeout }} | ||
| {% endif %} | ||
| {% if netflow.active_timeout is vyos_defined %} | ||
| options ipt_NETFLOW active_timeout={{ netflow.active_timeout }} | ||
| {% endif %} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
interface-definitions/include/version/flow-accounting-version.xml.i
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| <!-- include start from include/version/flow-accounting-version.xml.i --> | ||
| <syntaxVersion component='flow-accounting' version='2'></syntaxVersion> | ||
| <syntaxVersion component='flow-accounting' version='3'></syntaxVersion> | ||
| <!-- include end --> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not forget to remove mentions about
pmacct(after merging) in the vyos-buildThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you, I missed that!
Here is PR: vyos/vyos-build#1030
I'll make it non-draft when ipt_NETFLOW is merged.