ospf: T7297: fix redistribute-table

[hedrok]

OSPF: fix redistribute-table

Requires FRR to support redistribute table-direct for ospf (see 'Related PR(s)')

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T7297

Related PR(s)

vyos/vyos-build#1026

How to test / Smoketest result

Described in task in detail. Fix also requires adding

set protocols ospf table 10

On both sides.

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[c-po]

Please extend the smoketests to also cover the code-path for the new redistribute-table vtyshcommand

[hedrok]

@c-po Thanks, I've expanded smoketest/scripts/cli/test_protocols_ospf.py to test this.

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) ❌ failed
• CLI Smoketests VPP 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• Config tests VPP 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed

[c-po]

Change looks reasonable and extended with a dedicated smoketest validating the resulting FRR configuration.

[jestabro]

Smoketest included; looks good.