Skip to content

kea: T7281: Fix Kea 3.0 service failures - #4743

Merged
c-po merged 4 commits into
vyos:currentfrom
sarthurdev:kea3.0
Sep 23, 2025
Merged

kea: T7281: Fix Kea 3.0 service failures#4743
c-po merged 4 commits into
vyos:currentfrom
sarthurdev:kea3.0

Conversation

@sarthurdev

@sarthurdev sarthurdev commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Change summary

Original PR had failures that were missed by faulty test environment. This PR resolves the service start failures.

Known issues with VRF DHCP servers still crashing, fix is in progress and will be a new PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_dhcp-server.py
DEBUG - test_dhcp_dynamic_dns_update (__main__.TestServiceDHCPServer.test_dhcp_dynamic_dns_update) ... ok
DEBUG - test_dhcp_exclude_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_in_range) ... ok
DEBUG - test_dhcp_exclude_not_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_not_in_range) ... ok
DEBUG - test_dhcp_high_availability (__main__.TestServiceDHCPServer.test_dhcp_high_availability) ... ok
DEBUG - test_dhcp_high_availability_standby (__main__.TestServiceDHCPServer.test_dhcp_high_availability_standby) ... ok
DEBUG - test_dhcp_hostsd_lease_sync (__main__.TestServiceDHCPServer.test_dhcp_hostsd_lease_sync) ... ok
DEBUG - test_dhcp_multiple_pools (__main__.TestServiceDHCPServer.test_dhcp_multiple_pools) ... ok
DEBUG - test_dhcp_on_interface_with_vrf (__main__.TestServiceDHCPServer.test_dhcp_on_interface_with_vrf) ... ok
DEBUG - test_dhcp_relay_server (__main__.TestServiceDHCPServer.test_dhcp_relay_server) ... ok
DEBUG - test_dhcp_single_pool_options (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options) ... ok
DEBUG - test_dhcp_single_pool_options_scoped (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options_scoped) ... ok
DEBUG - test_dhcp_single_pool_range (__main__.TestServiceDHCPServer.test_dhcp_single_pool_range) ... ok
DEBUG - test_dhcp_single_pool_static_mapping (__main__.TestServiceDHCPServer.test_dhcp_single_pool_static_mapping) ... ok
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 13 tests in 55.994s
DEBUG - 
DEBUG - OK

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_dhcpv6-server.py
DEBUG - test_global_nameserver (__main__.TestServiceDHCPv6Server.test_global_nameserver) ... ok
DEBUG - test_prefix_delegation (__main__.TestServiceDHCPv6Server.test_prefix_delegation) ... ok
DEBUG - test_single_pool (__main__.TestServiceDHCPv6Server.test_single_pool) ... ok
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 3 tests in 11.578s
DEBUG - 
DEBUG - OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sarthurdev sarthurdev added the bp/circinus Create automatic backport for circinus label Sep 22, 2025
@github-actions

github-actions Bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@sarthurdev sarthurdev changed the title kea: T7821: Fix Kea 3.0 service failures kea: T7281: Fix Kea 3.0 service failures Sep 22, 2025
c-po
c-po approved these changes Sep 23, 2025
View reviewed changes

@c-po c-po left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust to KEA3 structure

@sever-sever

sever-sever commented Sep 23, 2025

Copy link
Copy Markdown
Member

Probably not related to this PR

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_vrf.py
DEBUG - test_dhcp_single_pool (__main__.VRFTest.test_dhcp_single_pool) ... FAIL
DEBUG - test_dhcp_single_pool (__main__.VRFTest.test_dhcp_single_pool) ... ERROR
DEBUG - test_dhcpv6_single_pool (__main__.VRFTest.test_dhcpv6_single_pool) ... FAIL
DEBUG - test_dhcpv6_single_pool (__main__.VRFTest.test_dhcpv6_single_pool) ... ERROR

@sarthurdev

sarthurdev commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

I'll investigate the failures in an hour. Might be in scope to include in this PR.

@sarthurdev sarthurdev removed the bp/circinus Create automatic backport for circinus label Sep 23, 2025
@sarthurdev

sarthurdev commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

Just waiting for smoketests to complete.

Removed backport label, will create a manual backport.

@sarthurdev

sarthurdev commented Sep 23, 2025

Copy link
Copy Markdown
Member Author 
DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_dhcp-server.py
DEBUG - test_dhcp_dynamic_dns_update (__main__.TestServiceDHCPServer.test_dhcp_dynamic_dns_update) ... ok
DEBUG - test_dhcp_exclude_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_in_range) ... ok
DEBUG - test_dhcp_exclude_not_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_not_in_range) ... ok
DEBUG - test_dhcp_high_availability (__main__.TestServiceDHCPServer.test_dhcp_high_availability) ... ok
DEBUG - test_dhcp_high_availability_standby (__main__.TestServiceDHCPServer.test_dhcp_high_availability_standby) ... ok
DEBUG - test_dhcp_hostsd_lease_sync (__main__.TestServiceDHCPServer.test_dhcp_hostsd_lease_sync) ... ok
DEBUG - test_dhcp_multiple_pools (__main__.TestServiceDHCPServer.test_dhcp_multiple_pools) ... ok
DEBUG - test_dhcp_on_interface_with_vrf (__main__.TestServiceDHCPServer.test_dhcp_on_interface_with_vrf) ... ok
DEBUG - test_dhcp_relay_server (__main__.TestServiceDHCPServer.test_dhcp_relay_server) ... ok
DEBUG - test_dhcp_single_pool_options (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options) ... ok
DEBUG - test_dhcp_single_pool_options_scoped (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options_scoped) ... ok
DEBUG - test_dhcp_single_pool_range (__main__.TestServiceDHCPServer.test_dhcp_single_pool_range) ... ok
DEBUG - test_dhcp_single_pool_static_mapping (__main__.TestServiceDHCPServer.test_dhcp_single_pool_static_mapping) ... ok
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 13 tests in 56.199s
DEBUG - 
DEBUG - OK
DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_dhcpv6-server.py
DEBUG - test_global_nameserver (__main__.TestServiceDHCPv6Server.test_global_nameserver) ... ok
DEBUG - test_prefix_delegation (__main__.TestServiceDHCPv6Server.test_prefix_delegation) ... ok
DEBUG - test_single_pool (__main__.TestServiceDHCPv6Server.test_single_pool) ... ok
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 3 tests in 11.700s
DEBUG - 
DEBUG - OK
DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_vrf.py
DEBUG - test_dhcp_single_pool (__main__.VRFTest.test_dhcp_single_pool) ... ok
DEBUG - test_dhcpv6_single_pool (__main__.VRFTest.test_dhcpv6_single_pool) ... ok
DEBUG - test_vrf_assign_interface (__main__.VRFTest.test_vrf_assign_interface) ... ok
DEBUG - test_vrf_bind_all (__main__.VRFTest.test_vrf_bind_all) ... ok
DEBUG - test_vrf_conntrack (__main__.VRFTest.test_vrf_conntrack) ... ok
DEBUG - test_vrf_disable_forwarding (__main__.VRFTest.test_vrf_disable_forwarding) ... ok
DEBUG - test_vrf_ip_ipv6_nht (__main__.VRFTest.test_vrf_ip_ipv6_nht) ... ok
DEBUG - test_vrf_ip_ipv6_protocol_non_existing_route_map (__main__.VRFTest.test_vrf_ip_ipv6_protocol_non_existing_route_map) ... ok
DEBUG - test_vrf_ip_protocol_route_map (__main__.VRFTest.test_vrf_ip_protocol_route_map) ... ok
DEBUG - test_vrf_ipv6_protocol_route_map (__main__.VRFTest.test_vrf_ipv6_protocol_route_map) ... ok
DEBUG - test_vrf_link_local_ip_addresses (__main__.VRFTest.test_vrf_link_local_ip_addresses) ... ok
DEBUG - test_vrf_loopbacks_ips (__main__.VRFTest.test_vrf_loopbacks_ips) ... ok
DEBUG - test_vrf_static_route (__main__.VRFTest.test_vrf_static_route) ... ok
DEBUG - test_vrf_table_id_is_unalterable (__main__.VRFTest.test_vrf_table_id_is_unalterable) ... ok
DEBUG - test_vrf_vni_add_change_remove (__main__.VRFTest.test_vrf_vni_add_change_remove) ... ok
DEBUG - test_vrf_vni_and_table_id (__main__.VRFTest.test_vrf_vni_and_table_id) ... ok
DEBUG - test_vrf_vni_duplicates (__main__.VRFTest.test_vrf_vni_duplicates) ... ok
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 17 tests in 373.446s
DEBUG - 
DEBUG - OK

sever-sever
sever-sever reviewed Sep 23, 2025
View reviewed changes
Comment thread src/etc/sudoers.d/vyos
@github-actions

github-actions Bot commented Sep 23, 2025

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

sever-sever
sever-sever approved these changes Sep 23, 2025
View reviewed changes

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VRF issue is another bug and will be fixed later.
Approved those changes.

@c-po c-po added the bp/circinus Create automatic backport for circinus label Sep 23, 2025
@c-po
c-po merged commit 9952d21 into vyos:current Sep 23, 2025
19 of 20 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow and removed mirror-initiated This PR initiated for mirror sync workflow labels Sep 23, 2025
@andamasov andamasov removed the bp/circinus Create automatic backport for circinus label May 9, 2026
@github-actions github-actions Bot added the rebase label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sever-sever sever-sever sever-sever approved these changes
@c-po c-po c-po approved these changes
@dmbaturin dmbaturin Awaiting requested review from dmbaturin
@jestabro jestabro Awaiting requested review from jestabro

Assignees

@sarthurdev sarthurdev

Labels

current mirror-completed rebase

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sarthurdev @sever-sever @c-po @andamasov @vyosbot