Skip to content

syslog: T4251: Rename "permitted-peers" to "permitted-peer" and improve TLS checks - #4824

Merged
sever-sever merged 2 commits into
vyos:currentfrom
alexandr-san4ez:T4251-current
Nov 28, 2025
Merged

syslog: T4251: Rename "permitted-peers" to "permitted-peer" and improve TLS checks#4824
sever-sever merged 2 commits into
vyos:currentfrom
alexandr-san4ez:T4251-current

Conversation

@alexandr-san4ez

@alexandr-san4ez alexandr-san4ez commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Change summary

  • Renamed permitted-peers to permitted-peer across templates, schema, and tests.
  • Added support for multiple permitted-peer entries and trimmed empty values.
  • Replaced TLS/UDP warning with ConfigError for strict validation.
  • Updated tests to use TCP for TLS and verified new validation logic.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

$ /usr/libexec/vyos/tests/smoke/cli/test_system_syslog.py
test_basic (__main__.TestRSYSLOGService.test_basic) ... ok
test_console (__main__.TestRSYSLOGService.test_console) ... ok
test_remote (__main__.TestRSYSLOGService.test_remote) ... ok
test_remote_tls (__main__.TestRSYSLOGService.test_remote_tls) ... ok
test_remote_tls_protocol_udp (__main__.TestRSYSLOGService.test_remote_tls_protocol_udp) ... ok
test_vrf_source_address (__main__.TestRSYSLOGService.test_vrf_source_address) ... ok

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@alexandr-san4ez
syslog: T4251: Rename "permitted-peers" to "permitted-peer" and impro…
6d4c6fb 
…ve TLS checks

- Renamed `permitted-peers` to `permitted-peer` across templates, schema, and tests.
- Added support for multiple `permitted-peer` entries and trimmed empty values.
- Replaced TLS/UDP warning with ConfigError for strict validation.
- Updated tests to use TCP for TLS and verified new validation logic.
@github-actions

github-actions Bot commented Oct 31, 2025 •
edited
Loading

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@alexandr-san4ez alexandr-san4ez mentioned this pull request Oct 31, 2025
Merged
1 task
@alexandr-san4ez
alexandr-san4ez marked this pull request as draft October 31, 2025 15:16
@alexandr-san4ez
alexandr-san4ez marked this pull request as ready for review November 3, 2025 14:46
@sever-sever
sever-sever requested review from c-po and dmbaturin November 3, 2025 15:21
sever-sever
sever-sever reviewed Nov 3, 2025
View reviewed changes
Comment thread src/migration-scripts/system/29-to-30 Outdated
@alexandr-san4ez
syslog: T4251: Implement migration script for TLS section
a3b37e6 
- Drop "tls enable" node (make "tls" a standalone key).
- Split "tls permitted-peers" list by commas into multiple "tls permitted-peer" entries.
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

dmbaturin
dmbaturin approved these changes Nov 8, 2025
View reviewed changes

@dmbaturin dmbaturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a multi node is indeed a lot better here because it allows users to easily delete individual entries, without copying/editing/pasting comma-separated values by hand.

sever-sever
sever-sever approved these changes Nov 28, 2025
View reviewed changes

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI refactoring, migration scripts added

@sever-sever
sever-sever merged commit f4d46db into vyos:current Nov 28, 2025
16 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow and removed mirror-initiated This PR initiated for mirror sync workflow labels Nov 28, 2025
@alexandr-san4ez

alexandr-san4ez commented Nov 28, 2025

Copy link
Copy Markdown
Contributor Author

@dmbaturin and @sever-sever could you also review documentation PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes
@sever-sever sever-sever sever-sever approved these changes
@c-po c-po Awaiting requested review from c-po

Assignees

@alexandr-san4ez alexandr-san4ez

Labels

current mirror-completed rebase

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexandr-san4ez @dmbaturin @sever-sever @vyosbot