firewall: T7112: Default action drop fails - #4834
Merged
Merged
Conversation
|
👍 |
Prevent `KeyError` by safely handling missing 'member' dict in zone config. Add smoketest to verify commit fails gracefully when zone has no interfaces.
alexandr-san4ez
force-pushed
the
T7112-current
branch
from
November 5, 2025 07:30
5e20adf to
909780c
Compare
|
CI integration ❌ failed! Details
|
sarthurdev
approved these changes
Nov 6, 2025
sarthurdev
left a comment
Member
There was a problem hiding this comment.
Fixes KeyError if member not defined. Code looks good and includes smoketest (passes).
sever-sever
approved these changes
Nov 6, 2025
sever-sever
left a comment
Member
There was a problem hiding this comment.
Do not allow the use of action without an interface if it is not local zone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Prevent
KeyErrorby safely handling missing 'member' dict in zone config.Add smoketest to verify commit fails gracefully when zone has no interfaces.
Types of changes
Related Task(s)
Manual test
Smoketest
Checklist: