T7965: reapply the QoS policy when the interface reconnect - #4837
T7965: reapply the QoS policy when the interface reconnect#4837opswill wants to merge 2 commits into
Conversation
|
👍 |
sarthurdev
left a comment
There was a problem hiding this comment.
Why not have the hooks in the root of src/etc/ppp/ip-up.d merged into a single file?
...
if [[ "$interface" == sstpc* ]]; then
/etc/ppp/ip-up.d/ppp-hook-scripts/96-vyos-sstpc-callback "$@"
fi
if [[ "$interface" == pppoe* ]]; then
/etc/ppp/ip-up.d/ppp-hook-scripts/99-vyos-pppoe-callback "$@"
/etc/ppp/ip-up.d/ppp-hook-scripts/99-vyos-pppoe-qos "$@"
fi
if [ -f "$WLB_PID_FILE" ]; then
/etc/ppp/ip-up.d/ppp-hook-scripts/99-vyos-pppoe-wlb "$@"
fi
|
@sarthurdev The bash scripts have been merged as you suggested; only one is left in the directory. |
|
CI integration 👍 passed! Details
|
|
@opswill I just wanted to add a short comment on this - it‘s not that we do not appreciate this idea. I am currently mocking up a NETLINK daemon which we could use to hook into and drop all these helper scripts. |
|
@c-po No worries at all. My patch was just intended as a direct fix for the immediate issue I encountered as a user. I completely understand that from a maintainer's perspective, a more proper solution is preferable. |
|
@opswill Thanks for the effort and for bringing the issue to our attention! We think we'll move forward with the netlink daemon to have a general solution to this type of problems. Your future contributions are welcome. |
pppoe interfaces may lose QoS config on reconnect. This PR reapplies the QoS policy when the interface comes up.
Change summary
QoS Fix: Adds a PPPoE hook script to /etc/ppp/ip-up.d/ to ensure QoS configuration is correctly reapplied and does not get lost when the PPPoE connection reconnects.
Performance Fix: As mentioned in T7965: reapply the QoS policy when the interface reconnect #4816, To avoid the significant BRAS overhead issue caused by Python interpreter startup, the QoS helper is now executed through Bash scripts.
Types of changes
Related Task(s)
https://vyos.dev/T7965
Related PR(s)
How to test / Smoketest result
Checklist: