T7994: fix regression in check for previous installations on install - #4849
Merged
jestabro merged 1 commit intoNov 17, 2025
Merged
Conversation
After T7836: move bind mount of /config to vyos-1x, the bind mount is configured at boot, not within the initrd. On image install, one needs to check for previous installations in the resident directory /opt/vyatta/etc/config of the mounted disk.
|
👍 |
|
CI integration 👍 passed! Details
|
Contributor
|
Fix works for me, previous installation found and config copied |
sarthurdev
approved these changes
Nov 17, 2025
sarthurdev
left a comment
sarthurdev
left a comment
Member
There was a problem hiding this comment.
Change makes sense and fix verified by Alex.
vyosbot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
After T7836: move bind mount of /config to vyos-1x, the bind mount is configured at boot, not within the initrd. On image install, one needs to check for previous installations in the resident directory /opt/vyatta/etc/config of the mounted disk.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
As in the task description, one can mount the built image in an existing vm and boot from iso; image install. One will see previous image found and config dir copied.
Checklist: