Skip to content

T7870: Kernel add option CONFIG_NO_HZ_FULL - #1045

Merged
dmbaturin merged 1 commit into
vyos:currentfrom
sever-sever:7870
Sep 29, 2025
Merged

T7870: Kernel add option CONFIG_NO_HZ_FULL#1045
dmbaturin merged 1 commit into
vyos:currentfrom
sever-sever:7870

Conversation

@sever-sever

@sever-sever sever-sever commented Sep 26, 2025

Copy link
Copy Markdown
Member

Change summary

Add options CONFIG_NO_HZ_FULL and CONFIG_RCU_NOCB_CPU for:

  • system option kernel cpu nohz-full
  • system option kernel cpu rcu-no-cbs

Fixes:

Sep 26 14:47:11 r14 kernel: Kernel command line: BOOT_IMAGE=/boot/2025.09.26-1054-integration/vmlinuz boot=live rootdelay=5 noautologin net.ifnames=0 biosdevname=0 vyos-union=/boot/2025.09.26-1054-integration hpet=disable mce=off nosoftlockup isolcpus=2-3 nohz_full=2-3 rcu_nocbs=2-3 nmi_watchdog=0 numa_balancing=disable default_hugepagesz=2M hugepagesz=2M hugepages=4096 console=tty0
Sep 26 14:47:11 r14 kernel: Housekeeping: nohz unsupported. Build with CONFIG_NO_HZ_FULL
Sep 26 14:47:11 r14 kernel: Unknown kernel command line parameters "noautologin BOOT_IMAGE=/boot/2025.09.26-1054-integration/vmlinuz boot=live biosdevname=0 vyos-union=/boot/2025.09.26-1054-integration nohz_full=2-3 rcu_nocbs=2-3", will be passed to user space.
Sep 26 14:47:11 r14 kernel: random: crng init done

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Reproduce

set system option kernel cpu isolate-cpus '2-3'
set system option kernel cpu nohz-full '2-3'
set system option kernel cpu rcu-no-cbs '2-3'

Reboot the system, and check logs

Sep 26 14:47:11 r14 kernel: Kernel command line: BOOT_IMAGE=/boot/2025.09.26-1054-integration/vmlinuz boot=live rootdelay=5 noautologin net.ifnames=0 biosdevname=0 vyos-union=/boot/2025.09.26-1054-integration hpet=disable mce=off nosoftlockup isolcpus=2-3 nohz_full=2-3 rcu_nocbs=2-3 nmi_watchdog=0 numa_balancing=disable default_hugepagesz=2M hugepagesz=2M hugepages=4096 console=tty0
Sep 26 14:47:11 r14 kernel: Housekeeping: nohz unsupported. Build with CONFIG_NO_HZ_FULL
Sep 26 14:47:11 r14 kernel: Unknown kernel command line parameters "noautologin BOOT_IMAGE=/boot/2025.09.26-1054-integration/vmlinuz boot=live biosdevname=0 vyos-union=/boot/2025.09.26-1054-integration nohz_full=2-3 rcu_nocbs=2-3", will be passed to user space.
Sep 26 14:47:11 r14 kernel: random: crng init done

Before fix:

vyos@r14:~$ zcat /proc/config.gz | grep CONFIG_NO_HZ_FULL
# CONFIG_NO_HZ_FULL is not set
vyos@r14:~$ 

vyos@r14:~$ zcat /proc/config.gz | grep CONFIG_RCU_NOCB_CPU
vyos@r14:~$

After fix:

Sep 29 11:42:27 r14 kernel: NO_HZ: Full dynticks CPUs: 2-3.
Sep 29 11:42:27 r14 kernel: rcu:         Offload RCU callbacks from CPUs: 2-3.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Add options CONFIG_NO_HZ_FULL and CONFIG_RCU_NOCB_CPU for:
 - system option kernel cpu nohz-full
 - system option kernel cpu rcu-no-cbs

Fixes:
```
kernel: Housekeeping: nohz unsupported. Build with CONFIG_NO_HZ_FULL
r14 kernel: Unknown kernel command line parameters
```
@github-actions

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@sarthurdev sarthurdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds needed kernel config for existing CLI

@dmbaturin dmbaturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely a good idea to set NO_HZ_FULL explicitly even regardless of that CLI bug.

@dmbaturin
dmbaturin merged commit f7d16af into vyos:current Sep 29, 2025
8 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

5 participants