Skip to content

T7909: FRR EIGRP - Handling for malformed update msgs - #1053

Merged
dmbaturin merged 1 commit into
vyos:currentfrom
ritika0313:T7909-eigrp-malformed-packets-handling
Oct 14, 2025
Merged

T7909: FRR EIGRP - Handling for malformed update msgs#1053
dmbaturin merged 1 commit into
vyos:currentfrom
ritika0313:T7909-eigrp-malformed-packets-handling

Conversation

@ritika0313

Copy link
Copy Markdown
Contributor

This patch fixes the crashes happening upon receipt of malformed update packets carrying routes other than IPv4 Internal routes. For packets carrying IPv4 Inernal routes, a subsequent patch is required

Change summary

This patch fixes the crashes happening upon receipt of malformed update packets carrying routes other than IPv4 Internal routes. The crash happens because the code is trying to read more data in TLVs than is available in the packet stream. Fix is implemented by first checking the length of available data in the stream before reading/accessing it. If sufficient data is not present to read, it is handled appropriately.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • [x ] I have read the CONTRIBUTING document
  • [x ] I have linked this PR to one or more Phabricator Task(s)
  • [x ] My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions github-actions Bot added the current VyOS rolling release label Oct 6, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a patch to FRR's EIGRP implementation to fix crashes caused by malformed update packets. The patch addresses the issue where code attempts to read more data from TLV (Type-Length-Value) structures than is available in the packet stream.

  • Adds bounds checking before reading packet data to prevent crashes
  • Implements graceful handling of unknown TLV types with proper validation
  • Adds safety checks for packet header lengths and TLV structure integrity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/package-build/frr/patches/frr/0009-T7909-eigrp-malformed-update-fix.patch Outdated
@ritika0313 ritika0313 changed the title FRR: T7909: EIGRP - Added handling for malformed update msgs T7909: FRR EIGRP - Added handling for malformed update msgs Oct 7, 2025
@ritika0313 ritika0313 changed the title T7909: FRR EIGRP - Added handling for malformed update msgs T7909: FRR EIGRP - Handling for malformed update msgs Oct 7, 2025
This patch fixes the crashes happening upon receipt of malformed update packets carrying routes other than IPv4 Internal routes. For packets carrying IPv4 Inernal routes, a subsequent patch is required
@ritika0313
ritika0313 force-pushed the T7909-eigrp-malformed-packets-handling branch from 9bc941e to 3fcf5f9 Compare October 9, 2025 06:49
@github-actions

github-actions Bot commented Oct 10, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ritika0313

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

vyosbot added a commit to vyos/vyos-cla-signatures that referenced this pull request Oct 10, 2025

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged in the upstream FRRouting/frr#19699

@dmbaturin dmbaturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not expose EIGPR yet but the patch will not harm, so let's merge it.

@dmbaturin
dmbaturin merged commit 5e292f5 into vyos:current Oct 14, 2025
8 of 10 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

5 participants