build: T7828: use tomli instead of toml in the package build script - #1061
Merged
Conversation
|
👍 |
jestabro
approved these changes
Oct 21, 2025
jestabro
left a comment
Contributor
There was a problem hiding this comment.
Use python3-tomli package instead of python3-toml.
sever-sever
approved these changes
Oct 22, 2025
sever-sever
left a comment
Member
There was a problem hiding this comment.
Build several packages without issues
vyos_bld@7c396283ff2e:/vyos/tmp/vyos-build/scripts/package-build/ethtool$ ls -l
ltotal 1072
lrwxr-xr-x. 1 vyos_bld dialout 11 Oct 22 14:03 build.py -> ../build.py
drwxr-xr-x. 77 vyos_bld dialout 2464 Oct 22 14:06 ethtool
-rw-r--r--. 1 vyos_bld dialout 5438 Oct 22 14:06 ethtool_6.10-1_arm64.buildinfo
-rw-r--r--. 1 vyos_bld dialout 1279 Oct 22 14:06 ethtool_6.10-1_arm64.changes
-rw-r--r--. 1 vyos_bld dialout 200668 Oct 22 14:06 ethtool_6.10-1_arm64.deb
-rw-r--r--. 1 vyos_bld dialout 499688 Oct 22 14:06 ethtool-dbgsym_6.10-1_arm64.deb
-rw-r--r--. 1 vyos_bld dialout 380417 Oct 22 14:05 ethtool_debian_1%6.10-1.tar.gz
-rw-r--r--. 1 vyos_bld dialout 117 Oct 22 14:03 package.toml
vyos_bld@7c396283ff2e:/vyos/tmp/vyos-build/scripts/package-build/ethtool$
---
vyos_bld@7c396283ff2e:/vyos/tmp/vyos-build/scripts/package-build/ddclient$ ls -l
total 468
lrwxr-xr-x. 1 vyos_bld dialout 11 Oct 22 14:03 build.py -> ../build.py
drwxr-xr-x. 32 vyos_bld dialout 1024 Oct 22 14:05 ddclient
-rw-r--r--. 1 vyos_bld dialout 102072 Oct 22 14:05 ddclient_3.11.2-1_all.deb
---
vyos_bld@7c396283ff2e:/vyos/tmp/vyos-build/scripts/package-build/frr$ ls -l
total 47268
lrwxr-xr-x. 1 vyos_bld dialout 11 Oct 22 14:03 build.py -> ../build.py
drwxr-xr-x. 66 vyos_bld dialout 2112 Oct 22 14:16 frr
-rw-r--r--. 1 vyos_bld dialout 11682 Oct 22 14:16 frr_10.2.4-0_arm64.buildinfo
-rw-r--r--. 1 vyos_bld dialout 3927 Oct 22 14:16 frr_10.2.4-0_arm64.changes
-rw-r--r--. 1 vyos_bld dialout 5560868 Oct 22 14:16 frr_10.2.4-0_arm64.deb
-rw-r--r--. 1 vyos_bld dialout 22173612 Oct 22 14:16 frr-dbgsym_10.2.4-0_arm64.deb
-rw-r--r--. 1 vyos_bld dialout 1957976 Oct 22 14:15 frr-doc_10.2.4-0_all.deb
-rw-r--r--. 1 vyos_bld dialout 54480 Oct 22 14:15 frr-pythontools_10.2.4-0_all.deb
-rw-r--r--. 1 vyos_bld dialout 48348 Oct 22 14:15 frr-rpki-rtrlib_10.2.4-0_arm64.deb
-rw-r--r--. 1 vyos_bld dialout 96880 Oct 22 14:15 frr-rpki-rtrlib-dbgsym_10.2.4-0_arm64.deb
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Use python3-tomli in the build script. That allows us to get rid of the python3-toml dependency since this is the last place where it was used.
Types of changes
Related Task(s)
Related PR(s)
Checklist: