T8085: Do not hardcode values in kernel build scripts - #1075
Merged
Conversation
Add architecture detection for kernel configuration file.
|
👍 |
sever-sever
approved these changes
Dec 10, 2025
sever-sever
left a comment
Member
There was a problem hiding this comment.
Fix for the build kernel architecture.
The x86 was hardcoded in the build kernel script.
Fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Add architecture detection for kernel configuration file to replace the hardcoded value.
We can't specify it with the following one line:
KERNEL_CONFIG=arch/${ARCH}/configs/vyos_defconfig
It is caused by the current directory structure - amd64 config is stored in linux/arch/x86 directory in the kernel sources. That's why we have to specify every option separately. Both uname and dpkg utils return this value in format of "x86_64" or "armd64" strings.
Types of changes
Related Task(s)
Related PR(s)
Checklist: