Skip to content

T8085: Do not hardcode values in kernel build scripts - #1075

Merged
c-po merged 1 commit into
vyos:currentfrom
asklymenko:patch-3
Dec 10, 2025
Merged

T8085: Do not hardcode values in kernel build scripts#1075
c-po merged 1 commit into
vyos:currentfrom
asklymenko:patch-3

Conversation

@asklymenko

Copy link
Copy Markdown
Contributor

Change summary

Add architecture detection for kernel configuration file to replace the hardcoded value.

We can't specify it with the following one line:
KERNEL_CONFIG=arch/${ARCH}/configs/vyos_defconfig

It is caused by the current directory structure - amd64 config is stored in linux/arch/x86 directory in the kernel sources. That's why we have to specify every option separately. Both uname and dpkg utils return this value in format of "x86_64" or "armd64" strings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Add architecture detection for kernel configuration file.
@github-actions

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions github-actions Bot added the current VyOS rolling release label Dec 10, 2025

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the build kernel architecture.
The x86 was hardcoded in the build kernel script.
Fix it.

@c-po c-po left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De-hardcode Kernel config path

@c-po
c-po merged commit 39d836a into vyos:current Dec 10, 2025
8 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Dec 10, 2025
@asklymenko
asklymenko deleted the patch-3 branch January 29, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

5 participants