Skip to content

T8159: remove rest of pmacct - #1098

Merged
dmbaturin merged 1 commit into
vyos:currentfrom
hedrok:T8159-clean-up-after-pmacct
Jan 12, 2026
Merged

T8159: remove rest of pmacct#1098
dmbaturin merged 1 commit into
vyos:currentfrom
hedrok:T8159-clean-up-after-pmacct

Conversation

@hedrok

@hedrok hedrok commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Change summary

Apart from pmacctd service, package pmacct also provided nfacctd, sfacctd and uacctd. Remove mention about them as we've removed pmacct.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): remove last remnants of pmacct

Related Task(s)

https://vyos.dev/T8159

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Apart from pmacctd service, package pmacct also provided nfacctd,
sfacctd and uacctd. Remove mention about them as we've removed pmacct.
@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions github-actions Bot added the current VyOS rolling release label Jan 7, 2026

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pmacct was removed, remove related sysctl services

@sever-sever
sever-sever requested review from c-po and dmbaturin January 7, 2026 16:23

@dmbaturin dmbaturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ashamed to have missed these when I made PR to remove what I called the last remnants of pmacct. In any case, these are remnants of pmacct and they are useless now that pmacct is no longer used, so we should remove them.

@dmbaturin
dmbaturin merged commit 5667462 into vyos:current Jan 12, 2026
8 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jan 12, 2026
@hedrok
hedrok deleted the T8159-clean-up-after-pmacct branch January 12, 2026 20:19
@hedrok

hedrok commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

@dmbaturin You shouldn't be - it wasn't you, it was me :) #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

4 participants