Skip to content

Testsuite: T8375: verify proper serial console settings - #1155

Merged
sever-sever merged 2 commits into
vyos:currentfrom
c-po:kernel-serial-activation
Apr 13, 2026
Merged

Testsuite: T8375: verify proper serial console settings#1155
sever-sever merged 2 commits into
vyos:currentfrom
c-po:kernel-serial-activation

Conversation

@c-po

@c-po c-po commented Apr 5, 2026

Copy link
Copy Markdown
Member

Change summary

Now that the serial console definition is dynamically generated by the image installer, depending on the flavor data, it is time to validate the resulting CLI nodes and GRUB config.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Embedded into the smoketest platform, e.g. make testc

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 2 commits April 5, 2026 20:40
…nf commands

As there is also "set system console device <DEV> kernel", use a more specific
match criteria to avoid false positives.
Now that the serial console definition is dynamically generated by the image
installer, depending on the flavor data, it is time to validate the resulting
CLI nodes and GRUB config.
@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • Config tests 👍 passed

@jestabro jestabro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate console-type in qemu setup. NOTE that this requires
vyos/vyos-1x#5092
to be merged beforehand.

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix console type for smoketests

@sever-sever
sever-sever merged commit 880043d into vyos:current Apr 13, 2026
15 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 13, 2026
@c-po
c-po deleted the kernel-serial-activation branch April 20, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

5 participants