Skip to content

T8969: vyos-build failing to build, missing dependencies #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jestabro merged 3 commits into from
Jun 8, 2026
Merged

T8969: vyos-build failing to build, missing dependencies #1220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bad0dfc
T8969: vyos-build failing to build, missing dependencies. Add build s…
asklymenko Jun 8, 2026
91a74fd
T8969: vyos-build failing to build, missing dependencies. Modify giti…
asklymenko Jun 8, 2026
4811386
T8969: vyos-build failing to build, missing dependencies
asklymenko Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/live-build-config/archives/bookworm-backports.pref.chroot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: iproute2
Pin: release n=bookworm-backports
Pin-Priority: 600

Package: suricata libhtp2
Package: suricata
Pin: release n=bookworm-backports
Pin-Priority: 600

Expand Down
1 change: 1 addition & 0 deletions scripts/package-build/libhtp/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/libhtp/
1 change: 1 addition & 0 deletions scripts/package-build/libhtp/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../build.py
4 changes: 4 additions & 0 deletions scripts/package-build/libhtp/package.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[[packages]]
name = "libhtp2"
commit_id = "e851d98f"

@coderabbitai coderabbitai Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use full Git commit SHA for deterministic source pinning.

Line 3 pins commit_id to an abbreviated hash (e851d98f). For build reproducibility and long-term immutability, use the full 40-character SHA to avoid future ambiguity/collision in upstream history.

Suggested change 
-commit_id = "e851d98f"
+commit_id = "<full-40-char-commit-sha>"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
commit_id = "e851d98f"
commit_id = "e851d98f1234567890abcdef1234567890abcdef"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/package-build/libhtp/package.toml` at line 3, The commit_id field in
package.toml is pinned to an abbreviated SHA ("e851d98f"); replace it with the
full 40-character Git commit SHA to ensure deterministic source pinning (update
the commit_id value to the repository's full SHA for the intended commit).
Ensure the new value preserves quotes and TOML formatting and verify the full
SHA corresponds to the exact upstream commit referenced.

scm_url = "https://salsa.debian.org/pkg-suricata-team/pkg-libhtp.git"
Loading