T9010: Update Linux Kernel to 6.18.36 and re-fresh Intel OOT driver versions - #1224
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
🧰 Additional context used🔍 Remote MCPBased on the search results, I have gathered relevant context to help with reviewing this PR. Let me compile the key findings: Relevant Context for PR ReviewLinux Kernel 6.18.36 StatusLinux kernel 6.18.36 was released on June 19, 2026, and 6.18.35 was released on June 9, 2026. Version 6.18.36 contains important fixes. Intel i40e Driver v2.30.18 - Key Support AdditionThe i40e-2.30.18 release adds support for RHEL 9.8, RHEL 10.2, and includes minor bugfixes and improvements. Additionally, the v2.30.12 release added support for Ubuntu 26.04 LTS. This confirms the PR objective that the updated drivers now officially support RHEL 9.8, RHEL 10.2, and Ubuntu 26.04, as stated in the PR summary. Intel ice Driver v2.6.6 AvailabilityThe ice Linux Base Driver version 2.6.6 is for the 800 series devices, confirming the driver version specified in the PR. Kernel 6.18 Support ContextThe PR mentions removing a custom patch that provided Kernel 6.18 support. The search results indicate that newer driver versions contain features not yet merged upstream and are updated more frequently than in-tree kernel drivers, which explains why these out-of-tree driver updates now provide native Kernel 6.18 support without needing custom patches. Build Script ChangesThe PR correctly updates the build cleanup script to remove both the generated Debian directory and post-install script file, ensuring complete removal of packaging artifacts. Patch Removal ContextThe removal of the 📝 WalkthroughSummary by CodeRabbit
WalkthroughBumps ChangesKernel and Intel NIC Driver Updates
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/package-build/linux-kernel/build-intel-nic.sh`:
- Line 81: In the rm command on line 81, the variables ${DEBIAN_DIR} and
${DEBIAN_POSTINST} are unquoted, which can cause word-splitting and globbing
vulnerabilities. Quote both variable expansions (wrap them in double quotes) and
add the `--` separator after the flags to clearly separate the rm options from
the arguments being deleted.
In `@scripts/package-build/linux-kernel/package.toml`:
- Around line 52-65: The scm_url values for the three Intel NIC packages
(ixgbevf, i40e, and ice) in the package.toml file are using insecure http://
protocol instead of https://. Change each of the three scm_url entries for these
packages from "http://github.com/intel/..." to "https://github.com/intel/..." to
ensure secure source integrity during the clone operation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 65cde0e8-9c82-4e49-b0bc-9ba19f16fc78
📒 Files selected for processing (3)
data/defaults.tomlscripts/package-build/linux-kernel/build-intel-nic.shscripts/package-build/linux-kernel/package.toml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
ansible/ansible(manual)
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: build_iso
- GitHub Check: codeql-analysis-call / Analyze (python)
- GitHub Check: Mergify Merge Protections
- GitHub Check: Summary
🧰 Additional context used
🪛 Shellcheck (0.11.0)
scripts/package-build/linux-kernel/build-intel-nic.sh
[info] 81-81: Double quote to prevent globbing and word splitting.
(SC2086)
[info] 81-81: Double quote to prevent globbing and word splitting.
(SC2086)
🔇 Additional comments (2)
data/defaults.toml (1)
17-17: LGTM!scripts/package-build/linux-kernel/package.toml (1)
39-41: LGTM!Also applies to: 45-47, 51-51, 57-57, 63-63, 69-69
Update versions: * igb v5.20.28 * ixgbe v6.4.4 * ixgbevf v5.3.36 * i40e v2.30.18 * ice v2.6.6 * iavf v4.13.35
|
CI integration 👍 passed! Details
|
sever-sever
left a comment
sever-sever
left a comment
There was a problem hiding this comment.
Regular Kernel update
Update Intel drivers
Nice to test it in the rolling.
jestabro
left a comment
jestabro
left a comment
There was a problem hiding this comment.
Update kernel version and Intel OOT driver versions.
|
Tick the box to add this pull request to the merge queue (same as
|
vyos-bot
Bot
added
mirror-initiated
3 participants
Change summary
Regular Linux Kernel version update
Also bump the Intel OOT driver versions which ghained official support for RHEL 9.8, RHEL 10.2 and Ubuntu 26.04 - which means we can drop one of our custom patches which added support for Kernel 6.18
Update versions:
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Embedded Smoketests
Checklist: