Skip to content

T9013: Add FRR patch to fix BMP connect source-interface deletion #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sever-sever merged 1 commit into from
Jun 25, 2026
Merged

T9013: Add FRR patch to fix BMP connect source-interface deletion #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ...kage-build/frr/patches/frr/0025-bgpd-fix-bmp-connect-deletion-with-source-interface.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
From d8923603c8aab212e923dccc16de9bb4c22c6846 Mon Sep 17 00:00:00 2001
From: Nataliia Solomko <natalirs1985@gmail.com>
Date: Wed, 24 Jun 2026 16:03:45 +0300
Subject: [PATCH] bgpd: fix bmp connect deletion with source-interface

bmp_connect() rejects deletion when source-interface is provided.
The check compares the configured source-interface with the one
in the command. It uses !strcmp(), which is true when the strings
are equal. But this result feeds an if-block that rejects the
deletion. So the command is rejected exactly when the
source-interface is correct, and accepted when it is wrong.
Fix by changing !strcmp() to strcmp().
---
bgpd/bgp_bmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bgpd/bgp_bmp.c b/bgpd/bgp_bmp.c
index 40f70f5a7c..f8c3f1c838 100644
--- a/bgpd/bgp_bmp.c
+++ b/bgpd/bgp_bmp.c
@@ -2996,7 +2996,7 @@ DEFPY(bmp_connect,
/* connection deletion need same hostname port and interface */
if (ba->ifsrc || srcif)
if ((!ba->ifsrc) || (!srcif) ||
- !strcmp(ba->ifsrc, srcif)) {
+ strcmp(ba->ifsrc, srcif)) {
vty_out(vty,
"%% No such active connection found\n");
return CMD_WARNING;
--
2.51.0
Loading