Skip to content

T9187: Update accel-ppp-ng version to c7b67eb - #1275

Merged
sever-sever merged 1 commit into
rollingfrom
sever-sever-patch-1
Aug 18, 2026
Merged

T9187: Update accel-ppp-ng version to c7b67eb#1275
sever-sever merged 1 commit into
rollingfrom
sever-sever-patch-1

Conversation

@sever-sever

@sever-sever sever-sever commented Aug 18, 2026

Copy link
Copy Markdown
Member

Change summary

Fixes accel-ppp: vlan-mon does not create dynamic VLAN interfaces

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Update accel-ppp-ng version

Related Task(s)

https://vyos.dev/T9187

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Fixes accel-ppp: vlan-mon does not create dynamic VLAN interfaces
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 05943114-068f-4d1a-bca1-ba38bd3831e2

📥 Commits

Reviewing files that changed from the base of the PR and between da2b4d5 and 2bc92e4.

📒 Files selected for processing (1)
  • scripts/package-build/linux-kernel/package.toml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ansible/ansible (manual)

Included review availability: 4 reviews are currently available. Based on recent review activity, included reviews refill at 5 per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
🧰 Additional context used
🔍 Remote MCP vyos.dev

Relevant task context

  • T9187 is titled “accel-ppp: vlan-mon does not create dynamic VLAN interfaces on rolling” and is Open, High priority.
  • Reproduction: PPPoE discovery on a VLAN monitored by vlan-mon reaches the physical interface, but the dynamic VLAN interface is not created and no session starts.
  • Reported root cause: Linux 6.18 rejects accel-ppp’s ETH_P_ALL packet handler because vlan_pt.af_packet_net is unset. The upstream fix assigns &init_net.
  • Static VLAN interfaces and untagged PPPoE are explicitly reported as unaffected.
  • Task comments link to the corresponding accel-ppp-ng PR 36 and this VyOS PR 1275.
  • Keyword search returned T9187 as the only matching task.

Review implication: verify that commit c7b67eb contains/backports the af_packet_net = &init_net fix and that the package build uses that commit successfully.

🔇 Additional comments (1)
scripts/package-build/linux-kernel/package.toml (1)

21-21: 🎯 Functional Correctness

Keep commit_id = "c7b67eb". The commit contains the T9187 fix, and its Debian 12 build check succeeds.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the packaged accel-ppp-ng component to a newer revision.
    • Ensures builds use the latest specified package version.

Walkthrough

The package configuration updates the accel-ppp-ng source commit reference from 9654bb6 to c7b67eb.

Changes

Package reference

Layer / File(s) Summary
Update accel-ppp-ng commit reference
scripts/package-build/linux-kernel/package.toml:21
The accel-ppp-ng.commit_id value changes from 9654bb6 to c7b67eb.

Merge Risk: ⚪ Minimal · up to 2bc92

This updates accel-ppp-ng to the commit containing the dynamic VLAN interface fix, with a successful Debian 12 build check. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the package and the new commit reference, matching the main change in scripts/package-build/linux-kernel/package.toml.
Description check ✅ Passed The description explains that the accel-ppp-ng update fixes dynamic VLAN interface creation and links the change to task T9187.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch sever-sever-patch-1

Comment @coderabbitai help to get the list of available commands.

@c-po c-po left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump accel-ppp-ng package version

@sever-sever
sever-sever merged commit b84fb1a into rolling Aug 18, 2026
12 checks passed
@sever-sever
sever-sever deleted the sever-sever-patch-1 branch August 18, 2026 13:45
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants