Skip to content

T7557: Use Debian trixie as build base for container and VyOS image - #978

Closed
sever-sever wants to merge 18 commits into
vyos:currentfrom
sever-sever:T7557
Closed

T7557: Use Debian trixie as build base for container and VyOS image#978
sever-sever wants to merge 18 commits into
vyos:currentfrom
sever-sever:T7557

Conversation

@sever-sever

@sever-sever sever-sever commented Jun 16, 2025

Copy link
Copy Markdown
Member

Change summary

Use Debian trixie as the build base for the container vyos-build and the VyOS image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Update Debian distro as base

Related Task(s)

Related PR(s)

Above PRs are needed for build to succeed

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever
sever-sever marked this pull request as draft June 16, 2025 15:57
@github-actions

github-actions Bot commented Jun 16, 2025

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions github-actions Bot added the current VyOS rolling release label Jun 16, 2025
@c-po

c-po commented Jun 19, 2025

Copy link
Copy Markdown
Member

IMHO this is a pretty dangerous change as long as the base system is not also updated to trixie. We always changed the container and base system at once during the past.

@sever-sever

Copy link
Copy Markdown
Member Author

IMHO this is a pretty dangerous change as long as the base system is not also updated to trixie

It includes and updates the base system from the trixie repos if I didn't miss something.
The build fails at the moment, so marked it as draft

[2025-06-16 15:58:05] lb chroot_package-lists install
P: Begin queueing installation of package lists (install pass)...
Reading package lists... Done
Building dependency tree... Done
Package dctrl-tools is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'dctrl-tools' has no installation candidate
E: An unexpected failure occurred, exiting...
P: Begin unmounting filesystems...
P: Saving caches...
Reading package lists... Done
Building dependency tree... Done
Traceback (most recent call last):
  File "/vyos/work/vyos-trixie/vyos-build/./build-vyos-image", line 692, in <module>
    cmd("lb build 2>&1")
    ~~~^^^^^^^^^^^^^^^^^
  File "/vyos/work/vyos-trixie/vyos-build/scripts/image-build/utils.py", line 84, in cmd
    raise OSError(f"Command '{command}' failed")
OSError: Command 'lb build 2>&1' failed
vyos_bld@039c315a3729:/vyos/work/vyos-trixie/vyos-build$ 

@sarthurdev

Copy link
Copy Markdown
Member

Moved it a bit further, still issues:

he following packages have unmet dependencies:
 accel-ppp : Depends: libpcre3 (>= 8.39) but it is not installable
 ipaddrcheck : Depends: libpcre3 but it is not installable
 kmod : Breaks: bash-completion (< 1:2.16.0-1) but 1:2.8-6 is to be installed
 libsnmp40 : Depends: libpcre3 but it is not installable
 libsnmp40t64 : Breaks: libsnmp40 (< 5.9.4+dfsg-2)
 vyatta-cfg : Depends: libvyatta-cfg1 (>= 0.102.0+vyos2+current5) but it is not going to be installed
              Depends: unionfs-fuse but it is not installable
              Depends: libboost-filesystem1.74.0 but it is not installable

@sarthurdev sarthurdev mentioned this pull request Jun 21, 2025
10 tasks
@sarthurdev

Copy link
Copy Markdown
Member

Fixes still WIP:
vyatta-bash, vyatta-cfg, vyos-1x

Comment thread scripts/image-build/build-vyos-image Outdated
@sarthurdev
sarthurdev force-pushed the T7557 branch 5 times, most recently from 3541c55 to 8403bfc Compare June 24, 2025 22:29

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SNMP should be removed there if we do not build it.

net-snmp:
- 'scripts/package-build/net-snmp/**'

if [ "${{ steps.changes.outputs.net-snmp }}" == "true" ]; then
trigger_build "net-snmp"
fi

  • addition unionfs-fuse to trigger re-build

@sarthurdev
sarthurdev force-pushed the T7557 branch 2 times, most recently from 0bba5a1 to d3065f9 Compare June 26, 2025 12:40
@sarthurdev
sarthurdev force-pushed the T7557 branch 3 times, most recently from 85fb945 to b289703 Compare June 30, 2025 10:38
@github-actions

Copy link
Copy Markdown

Conflicts Found. This pull request has conflicts. Please resolve them before we can evaluate the pull request.

@sarthurdev
sarthurdev marked this pull request as ready for review June 30, 2025 19:48
@github-actions

Copy link
Copy Markdown

Conflicts Resolved. Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions

Copy link
Copy Markdown

Conflicts Found. This pull request has conflicts. Please resolve them before we can evaluate the pull request.

@github-actions

Copy link
Copy Markdown

Conflicts Resolved. Conflicts have been resolved. A maintainer will review the pull request shortly.

@dmbaturin dmbaturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Administrative decision: we will upgrade to Trixie only after VyOS 1.5 LTS is released.

There are two motivations for it:

  1. While @sarthurdev's work uncovered and fixed lot of known issues, the risk of unknown unknowns is difficult to estimate and it's better to handle it when we start working on the Trixie-based LTS branch (1.5 is Bookworm-based and will not benefit from that work).
  2. The hard removal of DSA key support in OpenSSH can leave people locked out of their systems and needs to go through a deprecation procedure. Some could argue that it's not a big deal for rolling, but the procedure for handling incompatible changes still should be the same, especially with really serious things like login mechanisms.

Please convert the PR to a draft.

@sever-sever
sever-sever marked this pull request as draft August 15, 2025 08:46
@dmbaturin

Copy link
Copy Markdown
Member

The idea to upgrade to Trixie is on hold now, so I'm closing this PR series — not because they are bad, we'll reopen and merge them when we are ready to upgrade.

@dmbaturin dmbaturin closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release

Development

Successfully merging this pull request may close these issues.

5 participants