Skip to content

T7636: Fix Makefile target for test-no-interfaces - #990

Merged
dmbaturin merged 1 commit into
vyos:currentfrom
MPStudyly:patch-1
Jul 21, 2025
Merged

T7636: Fix Makefile target for test-no-interfaces#990
dmbaturin merged 1 commit into
vyos:currentfrom
MPStudyly:patch-1

Conversation

@MPStudyly

Copy link
Copy Markdown
Contributor

Change summary

The changed target is calling tests for VPP, which require huge page support, thus always making the target fail.

As described in the linked task, the global target test might still be prone to fail when MATCH is set to something including the VPP test suite. A quick and easy fix would be to enable huge pages for that target as well, though that might break environments that provide limited support only (cloud infra maybe?). If such a change is welcomed, I can either add a dedicated commit to this PR or open a dedicated one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7636

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions

github-actions Bot commented Jul 17, 2025

Copy link
Copy Markdown

👍
No issues in PR Title / Commit Title

@github-actions

github-actions Bot commented Jul 17, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot added the current VyOS rolling release label Jul 17, 2025
@MPStudyly

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

lemeshovich added a commit to vyos/vyos-cla-signatures that referenced this pull request Jul 17, 2025
The target is calling tests for VPP, which require huge page support, thus always making the target fail.

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test-no-interfaces excludes interfaces, but does not exclude VPP from tests.
To pass the VPP tests from the PHONY test-no-interfaces it is necessary to have hugepages.
Or use the PHONY test-no-interfaces-no-vpp; this way, the VPP tests will be skipped.

Approve

@dmbaturin dmbaturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viacheslav described it already, no objections.

@dmbaturin
dmbaturin merged commit 28147b4 into vyos:current Jul 21, 2025
4 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jul 21, 2025
@MPStudyly
MPStudyly deleted the patch-1 branch July 21, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current VyOS rolling release mirror-completed

Development

Successfully merging this pull request may close these issues.

4 participants