T7636: Fix Makefile target for test-no-interfaces - #990
Merged
Conversation
|
👍 |
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
lemeshovich
added a commit
to vyos/vyos-cla-signatures
that referenced
this pull request
Jul 17, 2025
The target is calling tests for VPP, which require huge page support, thus always making the target fail.
sever-sever
approved these changes
Jul 18, 2025
sever-sever
left a comment
Member
There was a problem hiding this comment.
The test-no-interfaces excludes interfaces, but does not exclude VPP from tests.
To pass the VPP tests from the PHONY test-no-interfaces it is necessary to have hugepages.
Or use the PHONY test-no-interfaces-no-vpp; this way, the VPP tests will be skipped.
Approve
dmbaturin
approved these changes
Jul 21, 2025
dmbaturin
left a comment
Member
There was a problem hiding this comment.
Viacheslav described it already, no objections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
The changed target is calling tests for VPP, which require huge page support, thus always making the target fail.
As described in the linked task, the global target
testmight still be prone to fail whenMATCHis set to something including the VPP test suite. A quick and easy fix would be to enable huge pages for that target as well, though that might break environments that provide limited support only (cloud infra maybe?). If such a change is welcomed, I can either add a dedicated commit to this PR or open a dedicated one.Types of changes
Related Task(s)
https://vyos.dev/T7636
Related PR(s)
Checklist: