docs: Update HTTP API page to VyOS 1.5 standards - #2131
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used🔍 Remote MCP Context7Relevant review context
📝 WalkthroughSummary by CodeRabbit
WalkthroughRewrites ChangesHTTPS API Documentation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @LiudmylaNad's task in 3m 18s —— View job VyOS Documentation Review — PR #2131
Issues
Needs VerificationNone. All other claims cross-checked cleanly against
Stats
|
There was a problem hiding this comment.
Pull request overview
This PR updates the HTTP API documentation page (service https) to align with current VyOS 1.5 documentation conventions, improving structure, clarity, and discoverability while adding examples and more explicit configuration guidance.
Changes:
- Added MyST
html_meta(description,keywords) front matter for SEO/context. - Reorganized the configuration section into clearer subsections (HTTPS listener, TLS, API authentication) with expanded explanations.
- Added concrete configuration examples for each documented command and clarified default behaviors.
dmbaturin
left a comment
There was a problem hiding this comment.
Looks mostly good, I just added a few small suggestions.
Change Summary
This PR refactors the HTTP API page to comply with the current VyOS documentation style guide.
Changes:
Added value range for:
set service https port <1-65535>
set service https request-body-size-limit <1-256>
set service https api graphql authentication expiration <60-31536000>
set service https api graphql authentication secret-length <16-65535>
Related Task(s)
VD-3756
Related PR(s)
Backport
Checklist: