Skip to content

fix[tool]: fix layout export with nonreentrancy pragma on #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

cyberthirst
Copy link
Collaborator

@cyberthirst cyberthirst commented Apr 30, 2025

What I did

How I did it

  • included also getter definitions when iterating over functions during exports

Commit message

this commit fixes storage layout exports when pragma nonreentrancy is
on for getters (which were not being included in the layout).

How to verify it

  • added relevant tests

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (3a41220) to head (9d9b0f8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4621   +/-   ##
=======================================
  Coverage   92.49%   92.50%           
=======================================
  Files         128      128           
  Lines       18506    18510    +4     
  Branches     3208     3208           
=======================================
+ Hits        17118    17122    +4     
  Misses        944      944           
  Partials      444      444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title fix[lang]: fix reentrant lock storage export fix[tool]: fix reentrant lock storage export Apr 30, 2025
@charles-cooper charles-cooper changed the title fix[tool]: fix reentrant lock storage export fix[tool]: fix layout export with nonreentrancy pragma on Apr 30, 2025
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @cyberthirst i added a single comment 9d9b0f8

@charles-cooper charles-cooper merged commit 427e033 into vyperlang:master Apr 30, 2025
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants