fix[venom]: load elimination improvements #4807
Open
+228
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4807 +/- ##
==========================================
+ Coverage 93.28% 93.32% +0.04%
==========================================
Files 148 148
Lines 20561 20557 -4
Branches 3570 3567 -3
==========================================
+ Hits 19180 19185 +5
+ Misses 924 919 -5
+ Partials 457 453 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HodanPlodky
reviewed
Jan 8, 2026
| ops.extend([pred.label, val]) | ||
|
|
||
| assert len(ops) == 2 * len(existing_value), (ops, existing_value, inst) | ||
| if len(ops) != 2 * len(existing_value): |
Collaborator
There was a problem hiding this comment.
why this has to be the if and not assert. All the cases should be already short circuited in the for beforehand.
Co-authored-by: HodanPlodky <[email protected]>
- Fix phi operand count check: use len(preds) instead of len(existing_value) to handle cases where multiple predecessors store the same value - Add _normalize_operand to ensure consistent lattice keys for aliased pointers - Remove dead code (memloc is None check, store_opcode is not None) - Restore assertions for impossible states (analysis bugs) while keeping legitimate bail-outs as returns - Add tests for nested diamonds, multi-predecessor phi, and aliased pointers Co-Authored-By: Claude Opus 4.5 <[email protected]>
charles-cooper
approved these changes
Jan 9, 2026
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
approved, waiting for any more feedback from @HodanPlodky
Put `param` instructions first in entry blocks for tests that use the hevm harness. `venom_to_assembly.py:_prepare_stack_for_function` breaks on the first non-param instruction, so params must come before other instructions for stack setup to work correctly. Also remove `hevm=False` from tests that were previously disabled due to this issue. Co-Authored-By: Claude Opus 4.5 <[email protected]>
All `param` instructions must be contiguous at the start of entry block. The `%alias = %ptr` assignment was between two params, breaking stack setup. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture